[pull] master from freeCodeCamp:master#48
Merged
pull[bot] merged 56 commits intoMu-L:masterfrom Aug 20, 2020
Merged
Conversation
Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com> Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
…9360) * fix: Replace Array.prototype.sort and update old isSorted method. * fix: Change name of function from 'checkInBuiltSort' to 'checkBuilitInSort'. * fix: Change name of function from 'checkBuilitInSort' to 'isBuiltInSortUsed'.
Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com>
* fix:Incorrect Usaage of setState in React Challenge * apply suggestion * also set stage usage in other challenges * fix setState usage in challenges * correct syntax * correct usage of useState in other files * add current message to state * remove current message from state * change connect redux to the message app * remove extra space
* feat: update learn into * fix: make text more readable * fix: adjust global font smoothing Co-authored-by: Ahmad Abdolsaheb <ahmad.abdolsaheb@gmail.com>
* fix: use forumLocation everywhere
Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com>
Using the English challenge as a source for the seed, solution and tests this takes the parts that can be translated from the translated version of the challenge. It also translates known comments in the seed.
Prevents multiple languages' challenges from being tested at once.
Without this change we would have to put in dummy localeTitle values. This defeats the point of making it required.
search and replace ```\n< with ```\n\n< to ensure there's an empty line before closing tags
* docs: add universal moderators handbook * Update docs/flight-manuals/moderator-handbook.md Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com> * Update docs/flight-manuals/moderator-handbook.md Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> * Update docs/flight-manuals/moderator-handbook.md Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com> * Update docs/flight-manuals/moderator-handbook.md Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com> Co-authored-by: Randell Dawson <5313213+RandellDawson@users.noreply.github.com> Co-authored-by: Nicholas Carrigan <nhcarrigan@gmail.com> Co-authored-by: Shaun Hamilton <51722130+Sky020@users.noreply.github.com>
Fixed a typo on the Sass Challenge "Create Reusable CSS with Mixins" where the word "vendor" was spelled incorrectly as "vender" in the test cases.
* feat: update backend project links Replace solution and remix Glitch links with equivalent Repl.it links in backend projects/challenges and intro pages. * fix: link and Repl.it casing * fix: update mention of glitch in testing challenge * Apply suggestions from code review Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> Co-authored-by: Mrugesh Mohapatra <1884376+raisedadead@users.noreply.github.com> Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
The Gatsby schema was breaking the React challenges (for some reason) this is a quick hotfix while I figure out what's going on.
Added missing closing bracket in test description in the tests section. Removed variable declared twice in the solution section.
* Fixed Redux dev tool plugin in production problem * Update client/src/redux/createStore.js Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com> * Update client/src/redux/createStore.js Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com> * Update client/src/redux/createStore.js Co-Authored-By: Tom <20648924+moT01@users.noreply.github.com> * Update client/src/redux/createStore.js Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> * Fixed ESLint error * Second try to fix linting issue * Third try to fix lint issues * Update client/src/redux/createStore.js Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> * Update client/src/redux/createStore.js Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com> * fix: use env.json for ENVIRONMENT Co-authored-by: Tom <20648924+moT01@users.noreply.github.com> Co-authored-by: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Prior to this, if a user first loaded a React challenge and then navigated to a JS challenge, they would see TypeError: Cannot read property 'presets' of undefined in the console and be unable to run tests or evaluate code until they reloaded the page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )