[pull] master from GNOME:master#564
Merged
pull[bot] merged 7 commits intoMu-L:masterfrom Aug 22, 2021
Merged
Conversation
Thanks to Massimo for reporting.
I first sink these, because they are floating references. This is actually quite unneeded here, because callbacks given to gimp_action_group_add_procedure_actions() (this is what filters_history_cmd_callback() is for) are not taking ownership of the GVariant anyway. Yet just in case this ever changes, this is the proper way to do it to avoid a double-free in the future. We take ownership in the calling code, hence we free the variable there after using it.
As explained in GTK docs, size groups are referenced by every internal widget hence can be immediately unref-ed after we added widgets in it. In the end, when the widgets are destroyed (thus removed from the group), the group will end up freed too. Reported by Massimo.
Let's move the g_date_time_format() to the inner block when it's actually used, hence also make sure we allocate and free at the same code level, which is a better practice to limit leaks. Reported by Massimo.
… default_mypaint_brush in gimp_core_config_finalize(). As reported by Massimo.
Thanks to Massimo for reporting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )