[pull] master from haproxy:master#213
Merged
pull[bot] merged 2 commits intoMu-L:masterfrom Sep 16, 2021
Merged
Conversation
When the LDAP response is parsed, the message length is not properly decoded. While it works for LDAP servers encoding it on 1 byte, it does not work for those using a multi-bytes encoding. Among others, Active Directory servers seems to encode messages or elements length on 4 bytes. In this patch, we only handle length of BindResponse messages encoded on 1, 2 or 4 bytes. In theory, it may be encoded on any bytes number less than 127 bytes. But it is useless to make this part too complex. It should be ok this way. This patch should fix the issue #1390. It should be backported to all stable versions. While it should be easy to backport it as far as 2.2, the patch will have to be totally rewritten for lower versions.
A lot of people encounter problems when trying to inject a certificate file which contains extra informations or empty lines. This patch adds a paragraph and a sanitizing example. Must be backported as far as 2.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )