Skip to content

Small modifications to CrvReco and CrvCoincidence modules - #552

Merged
kutschke merged 3 commits into
Mu2e:masterfrom
ehrlich-uva:crvfix2
Aug 5, 2021
Merged

Small modifications to CrvReco and CrvCoincidence modules#552
kutschke merged 3 commits into
Mu2e:masterfrom
ehrlich-uva:crvfix2

Conversation

@ehrlich-uva

@ehrlich-uva ehrlich-uva commented Jul 31, 2021

Copy link
Copy Markdown
Contributor

-small change to the no-fit pulse intervals in the CrvReco module
-added 2/4 layer coincidence option
-added variables to CrvCoincidence and CrvCoincidenceClusters
-bug fix in CrvCoincidence module
-removed xxxxxCollection.hh files for CrvCoincidence and CrvCoincidenceCluster, which affects a few files outside of CRVResponse

@FNALbuild

Copy link
Copy Markdown
Collaborator

Hi @ehrlich-uva,
You have proposed changes to files in these packages:

  • CRVAnalysis
  • RecoDataProducts
  • CRVResponse
  • Print
  • Validation
  • TEveEventDisplay
  • Analyses
  • CRVFilters

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on master.

⌛ The following tests have been triggered for 16ed06d: build (Build queue has 1 jobs)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild

Copy link
Copy Markdown
Collaborator

☔ The tests failed for 16ed06d.

Test Result Details
merge Merged 16ed06d at 5768fe9
build (prof) Log file. Build time: 12 min 35 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file. Return Code 9.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO 〰️ TODO (3) FIXME (2) in 13 files
clang-tidy 〰️ 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 16ed06d after being merged into the base branch at 5768fe9.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@FNALbuild

Copy link
Copy Markdown
Collaborator

📝 The HEAD of master has changed to 47a2661. Tests are now out of date.

@kutschke

Copy link
Copy Markdown
Contributor

The error in ceMix has been fixed in a recent merge. Rerunning the CI now.

@FNALbuild run build test

@FNALbuild

Copy link
Copy Markdown
Collaborator

⌛ The following tests have been triggered for 16ed06d: build (Build queue has 2 jobs)

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The tests passed at 16ed06d.

Test Result Details
merge Merged 16ed06d at 47a2661
build (prof) Log file. Build time: 13 min 45 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO 〰️ TODO (3) FIXME (2) in 13 files
clang-tidy 〰️ 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 16ed06d after being merged into the base branch at 47a2661.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@@ -160,7 +160,7 @@ BEGIN_PROLOG
PEthresholds : [ 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 ]
adjacentPulseTimeDifferences : [ 10 , 10 , 10 , 10 , 10 , 10 , 10 , 10 , 10 , 10 , 20 , 20 , 10 , 10 , 10 , 10 , 10 , 10 , 10 , 10 , 10 , 10 , 10 ] //ns

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider putting these parallel arrays of configs into a struct to simplify the configuration.

@kutschke kutschke self-assigned this Aug 2, 2021
@kutschke

kutschke commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

@oksuzian Yuri: Dave requested that you review this PR. When do you think you can get to it?

@ehrlich-uva Ralf: Do you plan to follow up on Dave's suggestion on this PR?

@FNALbuild

Copy link
Copy Markdown
Collaborator

📝 The HEAD of master has changed to 6751bf8. Tests are now out of date.

@oksuzian oksuzian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I'll be happy to try it out.

@kutschke

kutschke commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

@FNALbuild run build tests

@FNALbuild

Copy link
Copy Markdown
Collaborator

⌛ The following tests have been triggered for 16ed06d: build (Build queue has 2 jobs)

@FNALbuild

Copy link
Copy Markdown
Collaborator

☀️ The tests passed at 16ed06d.

Test Result Details
merge Merged 16ed06d at 6751bf8
build (prof) Log file. Build time: 14 min 03 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO 〰️ TODO (3) FIXME (2) in 13 files
clang-tidy 〰️ 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 16ed06d after being merged into the base branch at 6751bf8.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@kutschke
kutschke merged commit 3adc668 into Mu2e:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants