Small modifications to CrvReco and CrvCoincidence modules - #552
Conversation
|
Hi @ehrlich-uva,
which require these tests: build. @Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on master. ⌛ The following tests have been triggered for 16ed06d: build (Build queue has 1 jobs) |
|
☔ The tests failed for 16ed06d.
N.B. These results were obtained from a build of this Pull Request at 16ed06d after being merged into the base branch at 5768fe9. For more information, please check the job page here. |
|
📝 The HEAD of |
|
The error in ceMix has been fixed in a recent merge. Rerunning the CI now. @FNALbuild run build test |
|
⌛ The following tests have been triggered for 16ed06d: build (Build queue has 2 jobs) |
|
☀️ The tests passed at 16ed06d.
N.B. These results were obtained from a build of this Pull Request at 16ed06d after being merged into the base branch at 47a2661. For more information, please check the job page here. |
| @@ -160,7 +160,7 @@ BEGIN_PROLOG | |||
| PEthresholds : [ 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 , 8 ] | |||
| adjacentPulseTimeDifferences : [ 10 , 10 , 10 , 10 , 10 , 10 , 10 , 10 , 10 , 10 , 20 , 20 , 10 , 10 , 10 , 10 , 10 , 10 , 10 , 10 , 10 , 10 , 10 ] //ns | |||
There was a problem hiding this comment.
Please consider putting these parallel arrays of configs into a struct to simplify the configuration.
|
@oksuzian Yuri: Dave requested that you review this PR. When do you think you can get to it? @ehrlich-uva Ralf: Do you plan to follow up on Dave's suggestion on this PR? |
|
📝 The HEAD of |
oksuzian
left a comment
There was a problem hiding this comment.
Looks good.
I'll be happy to try it out.
|
@FNALbuild run build tests |
|
⌛ The following tests have been triggered for 16ed06d: build (Build queue has 2 jobs) |
|
☀️ The tests passed at 16ed06d.
N.B. These results were obtained from a build of this Pull Request at 16ed06d after being merged into the base branch at 6751bf8. For more information, please check the job page here. |
-small change to the no-fit pulse intervals in the CrvReco module
-added 2/4 layer coincidence option
-added variables to CrvCoincidence and CrvCoincidenceClusters
-bug fix in CrvCoincidence module
-removed xxxxxCollection.hh files for CrvCoincidence and CrvCoincidenceCluster, which affects a few files outside of CRVResponse