fix(recoMC): default NoFieldRun1B to the v40 Run1B geometry - #564
Merged
Conversation
NoFieldRun1B.fcl defaulted to geom_run1_b_v01.txt, a superseded geometry that replaced the 37-foil stopping target with a single 600 mm disk and moved the tracker and calorimeter to the extracted positions. The Run1B production geometry is geom_run1_b_v40.txt, which inherits geom_run1_a.txt untouched and adds the two-piece aluminium assembly at the TS5 face. No production job changes behaviour. Every caller sets services.GeometryService.inputFile explicitly: the live prodtools template templates/Run1B/reco.json and Tests/Run1BReco.fcl both select v40, and the frozen Run1Baa-Bai entries in prodtools data/Run1B/reco.json pin v01, v03 and v06 so they keep reproducing their original campaigns. The default therefore governs only bare invocation, where it now matches what Run1Ban and Run1Bap actually run. The header comment described the v01 layout and no longer applied. Requires Mu2e/Offline#1923, which adds geom_run1_b_v40.txt to Offline main. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
michaelmackenzie
approved these changes
Aug 10, 2026
michaelmackenzie
left a comment
michaelmackenzie
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me
Collaborator
|
☀️ The build tests passed at 1dacb73.
N.B. These results were obtained from a build of this Pull Request at 1dacb73 after being merged into the base branch at 20c93ed. For more information, please check the job page here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoFieldRun1B.fcl defaulted to geom_run1_b_v01.txt, a superseded geometry that replaced the 37-foil stopping target with a single 600 mm disk and moved the tracker and calorimeter to the extracted positions. The Run1B production geometry is geom_run1_b_v40.txt, which inherits geom_run1_a.txt untouched and adds the two-piece aluminium assembly at the TS5 face.
No production job changes behaviour. Every caller sets services.GeometryService.inputFile explicitly: the live prodtools template templates/Run1B/reco.json and Tests/Run1BReco.fcl both select v40, and the frozen Run1Baa-Bai entries in prodtools data/Run1B/reco.json pin v01, v03 and v06 so they keep reproducing their original campaigns. The default therefore governs only bare invocation, where it now matches what Run1Ban and Run1Bap actually run.
The header comment described the v01 layout and no longer applied.
Requires Mu2e/Offline#1923, which adds geom_run1_b_v40.txt to Offline main.