Basic modifications to make it compatible with KSP 1.3. No localization#888
Closed
alcidesv wants to merge 1 commit into
Closed
Basic modifications to make it compatible with KSP 1.3. No localization#888alcidesv wants to merge 1 commit into
alcidesv wants to merge 1 commit into
Conversation
Contributor
|
Can you redo the PR on the dev branch (just changing the PR branch in github seems to be a bad idea) ? Or I can use the changes I have in my local branch. |
Contributor
|
Also, without the Tuple changes please. I want to keep using my local version of smooth since I can't update the KSP one. |
Author
|
I'm not familiar with the project and the state of the 'dev' branch. Maybe you can take it from here? |
Contributor
|
Sure. Thanks for the work 👍 |
lamont-granquist
added a commit
that referenced
this pull request
May 28, 2026
Don't try to set the SMA based on desired altitude, but just circularize at whatever the apoapsis actually is. We could try to circularize at the precise altitude if the desired altitude < apo, but that could get more costly so I'm going to skip thinking about it (some people will want it, some people probably won't, heuristics will add more edge conditions and buttons and I don't think it is worth it). closes #1971 closes #888 (maybe)
lamont-granquist
added a commit
that referenced
this pull request
May 28, 2026
Don't try to set the SMA based on desired altitude, but just circularize at whatever the apoapsis actually is. We could try to circularize at the precise altitude if the desired altitude < apo, but that could get more costly so I'm going to skip thinking about it (some people will want it, some people probably won't, heuristics will add more edge conditions and buttons and I don't think it is worth it). closes #1971 closes #888 (maybe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.