Skip to content

chore: remove accidentally committed post-build step#138

Merged
clansty merged 1 commit into
MuNET-OSS:mainfrom
3096:main
Jul 8, 2026
Merged

chore: remove accidentally committed post-build step#138
clansty merged 1 commit into
MuNET-OSS:mainfrom
3096:main

Conversation

@3096

@3096 3096 commented Jul 8, 2026

Copy link
Copy Markdown

it was accidentally left in in the last PR.
build assets are not to be uploaded

Summary by Sourcery

Build:

  • 停止在 build.ps1 脚本中创建并重命名压缩的 build-assets 构件。
Original summary in English

Summary by Sourcery

Build:

  • Stop creating and renaming a zipped build-assets artifact in the build.ps1 script.

it was accidentally left in in the last PR.
build assets are not to be uploaded
@sourcery-ai

sourcery-ai Bot commented Jul 8, 2026

Copy link
Copy Markdown
审查者指南(在小型 PR 上折叠)

审查者指南

此 PR 通过移除一个意外提交的构建后步骤来简化 PowerShell 构建脚本。该步骤会在构建成功后,对构建产物进行压缩并重命名,以便作为 CI 构件上传。

按文件分类的变更

变更 详情 文件
移除在成功构建后,将构建产物打包为 zip/TOML 构件的构建后步骤。
  • 删除在 dotnet build 完成后检查 .\build-assets 目录的条件块。
  • 移除在压缩前删除已有 .\Output\build-assets.zip 的逻辑。
  • 移除从 .\build-assets 文件夹创建 .\Output\build-assets.zip 的 Compress-Archive 调用。
  • 移除删除已有 .\Output\AquaMai.build-assets.zip.toml 文件的清理逻辑,以及随后将 zip 重命名为 AquaMai.build-assets.zip.toml 的 Rename-Item 操作。
  • 保持核心构建行为(对 AquaMai.slnx 执行 dotnet build)不变。
build.ps1

提示与命令

与 Sourcery 交互

  • 触发新的审查: 在 pull request 中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审查评论。
  • 从审查评论生成 GitHub Issue: 在审查评论下回复,请 Sourcery 根据该评论创建一个 Issue。你也可以回复 @sourcery-ai issue 来从该评论创建一个 Issue。
  • 生成 pull request 标题: 在 pull request 标题的任意位置写上 @sourcery-ai,即可随时生成标题。你也可以在 pull request 中评论 @sourcery-ai title,随时(重新)生成标题。
  • 生成 pull request 摘要: 在 pull request 正文的任意位置写上 @sourcery-ai summary,即可在指定位置生成 PR 摘要。你也可以在 pull request 中评论 @sourcery-ai summary,随时(重新)生成摘要。
  • 生成审查者指南: 在 pull request 中评论 @sourcery-ai guide,即可随时(重新)生成审查者指南。
  • 一次性解决所有 Sourcery 评论: 在 pull request 中评论 @sourcery-ai resolve,即可将所有 Sourcery 评论标记为已解决。如果你已经处理完所有评论且不想再看到它们,这会很有用。
  • 一次性驳回所有 Sourcery 审查: 在 pull request 中评论 @sourcery-ai dismiss,即可驳回所有现有的 Sourcery 审查。若你想从头开始新的审查,这会特别有用——别忘了再评论一次 @sourcery-ai review 来触发新审查!

自定义你的使用体验

访问你的控制面板 以:

  • 启用或停用审查功能,例如 Sourcery 生成的 pull request 摘要、审查者指南等。
  • 更改审查语言。
  • 添加、移除或编辑自定义审查指令。
  • 调整其他审查设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR simplifies the PowerShell build script by removing an accidentally committed post-build step that zipped and renamed build assets for upload as CI artifacts.

File-Level Changes

Change Details Files
Remove the post-build step that packaged build-assets into a zip/TOML artifact after a successful build.
  • Delete the conditional block that checks for the .\build-assets directory after the dotnet build completes.
  • Remove logic that deletes any existing .\Output\build-assets.zip before compression.
  • Remove the Compress-Archive invocation that created .\Output\build-assets.zip from the .\build-assets folder.
  • Remove the cleanup of any existing .\Output\AquaMai.build-assets.zip.toml file and the subsequent Rename-Item that renamed the zip to AquaMai.build-assets.zip.toml.
  • Keep the core build behavior (dotnet build of AquaMai.slnx) unchanged.
build.ps1

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the post-build step in build.ps1 that zipped the build-assets directory and renamed it to AquaMai.build-assets.zip.toml for CI artifact extraction. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我已经审查了你的修改,一切看起来都很棒!


Sourcery 对开源项目是免费的——如果你觉得我们的审查有帮助,请考虑分享它们 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的审查。
Original comment in English

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@clansty clansty merged commit 3596b9b into MuNET-OSS:main Jul 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants