Migrate to Cloudflare workers by eyeseast · Pull Request #1311 · MuckRock/documentcloud-frontend

eyeseast · 2026-03-31T20:03:52Z

This moves us off Netlify and sets up deployments using Cloudflare Workers. It creates three distinct and separated environments:

previews
staging
production

Each one gets its own Wrangler file. Staging and production are static configs, previews are generated for each PR.

File	Worker Name	Domain	Deployed by
`wrangler.production.jsonc`	`documentcloud-frontend`	`www.documentcloud.org`	Workers Builds (from `main`)
`wrangler.staging.jsonc`	`documentcloud-frontend-staging`	`staging.documentcloud.org`	Workers Builds (from `main`)
`wrangler.preview.jsonc`	`dc-preview-<PR#>`	`preview-<PR#>.staging.documentcloud.org`	GitHub Actions (generated at CI time, not checked in)

This gives us a staging staging server for other services to use (#1286) and gives us previews like we have on Netlify.

One thing to note here: We're creating a new worker for each PR, and deleting it when we close/merge the PR. If we need to look at an old branch, we can reopen the PR.

Deployment

When we deploy this, we should:

Merge this PR
Delete the current DNS record for www.documentcloud.org, pointing to Netlify
Add a custom domain to the documentcloud-frontend worker for www.documentcloud.org

At that point, we'll be live on Cloudflare.

Closes #1286
Closes #1235
Closes #1257

Separately, we need to make sure these redirects are covered, either as SvelteKit routes or through the CF control panel:

# we don't have any of these
/.well-known/* /404.html 404
/ads.txt /404.html 404

# sometimes asset paths get mislaid
/documents/_app/* /_app/:splat
/documents/:id/_app/* /_app/:splat

# old URLs
/search/ /documents/
/app /documents/
/api/oembed.json https://api.www.documentcloud.org/api/oembed/

github-actions · 2026-04-01T19:57:18Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	58.63%	2380 / 4059
🔵	Statements	59.23%	2756 / 4653
🔵	Functions	60.58%	621 / 1025
🔵	Branches	59.34%	1460 / 2460

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
src/lib/api/addons.ts	70%	69.64%	61.11%	70%	82-187, 369-375
src/lib/api/types.d.ts	0%	0%	0%	0%
src/lib/components/addons/AddOnListItem.svelte	100%	50%	100%	100%
src/lib/components/addons/AddOnPin.svelte	0%	0%	0%	0%
src/lib/components/addons/AddOnsNavigation.svelte	100%	100%	100%	100%
src/lib/components/addons/History.svelte	0%	0%	0%	0%
src/lib/components/addons/Scheduled.svelte	0%	100%	0%	0%	83-94
src/lib/components/addons/ScheduledEvent.svelte	0%	100%	100%	0%	62
src/lib/components/addons/Selection.svelte	91.66%	50%	100%	85.71%	66, 81
src/lib/components/documents/ResultsList.svelte	95.23%	66.66%	100%	94.44%	199
src/lib/components/forms/AddOnDispatch.svelte	0%	100%	100%	0%	235-330
src/lib/components/forms/Search.svelte	0%	0%	0%	0%
src/lib/components/forms/Share.svelte	61.84%	57.14%	61.11%	60.34%	152-170, 151-167, 211, 223, 232, 244, 256, 278-281
src/lib/components/layouts/AddOnLayout.svelte	0%	0%	0%	0%	192-247
src/lib/components/sidebar/SidebarGroup.svelte	0%	0%	0%	0%
src/lib/components/sidebar/tests/Documents.demo.svelte	0%	0%	0%	0%
src/lib/components/storybook/ContextDecorator.svelte	0%	0%	0%	0%
src/lib/components/viewer/AnnotationLayer.svelte	0%	100%	0%	0%	224-253
src/lib/components/viewer/RedactionLayer.svelte	0%	0%	0%	0%

Generated in workflow #1187 for commit a6a3a13 by the Vitest Coverage Report Action

github-actions · 2026-04-03T01:58:40Z

Preview deployed: https://preview-1311.staging.documentcloud.org

duckduckgrayduck · 2026-04-07T18:11:24Z

The frontend staging URL: https://staging.documentcloud.org/home/
When I click login it directs me to production. The hover over link also says api.www.documentcloud.org/accounts/logi..

The deploy preview appears correctly routed and is working for me. It appears sometimes the redirect back to the deploy preview times out, but refreshing the page gets me logged in anyways.

duckduckgrayduck · 2026-04-07T18:16:46Z

Pinning & unpinning an Add-On seems to have broken

duckduckgrayduck · 2026-04-07T18:20:12Z

When I click to dispatch an Add-On it seems to freeze the top navigation bar, the notification doesn't appear (until a refresh) and I'm unable to use any of the other dropdowns.

If I have the "Explore Add-Ons" menu open and click to open an Add-On, the URL changes, but the Add-On doesn't open until a refresh

duckduckgrayduck · 2026-04-07T18:25:18Z

The Scraper & Klaxon Add-Ons, I presume because they don't have any documents needed in their context, open in full page view instead of with the current search. We should probably default to side panel view always to make it a consistent user experience and not have to have two possible paths. For the Scraper Add-On it asks us to put in a project ID too, so we would likely grab that from the search context

eyeseast · 2026-04-07T19:55:30Z

The staging url https://staging.documentcloud.org/home/ is an old build. It'll update when we merge this into main.

This is the url to test: https://preview-1311.staging.documentcloud.org/

duckduckgrayduck · 2026-04-07T20:13:01Z

The staging url https://staging.documentcloud.org/home/ is an old build. It'll update when we merge this into main.

This is the url to test: https://preview-1311.staging.documentcloud.org/

Yea, all the further testing was on the deploy preview

eyeseast · 2026-04-07T21:19:10Z

Add-On issues should be fixed now. There was an infinite loop happening in the <History> component.

mitchelljkotler

Just want to confirm that the redirects from _redirects were implemented outside of code in Cloudflare config?

eyeseast · 2026-04-08T15:47:21Z

Just want to confirm that the redirects from _redirects were implemented outside of code in Cloudflare config?

Yes. I'll add that to the deployment plan. There's no equivalent of that file in Cloudflare, so we either need to implement them in the control panel or as SvelteKit routes. Probably better to consolidate approaches anyway.

allanlasser · 2026-04-09T14:22:30Z

I would I'd prefer to have redirects saved into the codebase. Better accountability, easier to reference, and coupled to code changes that require them.

allanlasser · 2026-04-09T15:00:13Z

@@ -0,0 +1,55 @@
+# Cloudflare Workers Deployment


Delete before merging?

duckduckgrayduck · 2026-04-09T15:07:26Z

The Scraper & Klaxon Add-Ons, I presume because they don't have any documents needed in their context, open in full page view instead of with the current search. We should probably default to side panel view always to make it a consistent user experience and not have to have two possible paths. For the Scraper Add-On it asks us to put in a project ID too, so we would likely grab that from the search context

Still noticing this, but all other Add-Ons issues are fixed

eyeseast · 2026-04-09T15:14:02Z

The Scraper & Klaxon Add-Ons, I presume because they don't have any documents needed in their context, open in full page view instead of with the current search. We should probably default to side panel view always to make it a consistent user experience and not have to have two possible paths. For the Scraper Add-On it asks us to put in a project ID too, so we would likely grab that from the search context

That's how they look in production: https://www.documentcloud.org/add-ons/MuckRock/documentcloud-scraper-addon/.

We don't show the document search for Add-Ons that don't run on Documents. It's not related to this PR.

allanlasser · 2026-04-09T15:53:26Z

Aside from the remote stuff, everything else is working well for me.

allanlasser

Everything looks good to me!

This comment was marked as outdated.

Sign in to view

eyeseast added 4 commits April 1, 2026 08:33

basic cf worker config

12fdbfd

logging

56c394b

observability

176a6fc

envs

db45fce

eyeseast force-pushed the cloudflare-workers branch from f75c6ed to db45fce Compare April 1, 2026 12:34

eyeseast changed the base branch from 1233-svelte-5-common to main April 1, 2026 12:34

config

c7435c4

This comment was marked as outdated.

Sign in to view

eyeseast added 18 commits April 1, 2026 16:05

Try vite mode

b13b6d0

put it in package.json

b337422

Use sveltekits env

9157ba3

vars

c22ce6c

build vars

bae1381

no top-level build

3a732f7

Trying scripts

2d54d2b

Set APP_URL in the build script

f4be7a3

CF_PAGES_BRANCH

b2efb65

debug

34a16e5

WORKERS_CI_BRANCH

85180b8

Update workflows

5ddefcc

PUBLIC_ENV=production

78b405a

Set PUBLIC_ENV=development to match local tests

afc6115

Set env globally

6b21e77

Try to fix tests and warnings

4d135e7

Use staging.documentcloud.org

0e2a0ea

Trying a github multi-worker setup

08632f5

envs

caa30d4

eyeseast added 4 commits April 6, 2026 20:07

fix stories

4eec8d9

Stores and snippets don't get along

93d3d07

fromStore

fe87e03

preload fix

74e1c41

eyeseast added 2 commits April 7, 2026 17:05

Fix addon pinning

0e05b5a

Use onMount instead of effect for now

974c525

mitchelljkotler approved these changes Apr 8, 2026

View reviewed changes

allanlasser reviewed Apr 9, 2026

View reviewed changes

Comment thread src/config/config.js

Comment thread vite.config.js Outdated

Comment thread package.json Outdated

eyeseast added 2 commits April 9, 2026 12:32

Use local.staging.documentcloud.org instead of local.muckcloud.com

f7d0772

PUBLIC_ENV not NODE_ENV

c6fc826

allanlasser approved these changes Apr 9, 2026

View reviewed changes

eyeseast added 2 commits April 9, 2026 14:39

Remove bubble calls. Closes #1257

38e0856

Plan is done

a6a3a13

eyeseast marked this pull request as ready for review April 13, 2026 14:04

eyeseast merged commit 509ac54 into main Apr 13, 2026
12 of 13 checks passed

This was referenced Apr 13, 2026

Deleted documents remain available until cache expires #1146

Closed

Reorganize dependencies in package.json #1306

Closed

Conversation

eyeseast commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deployment

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

github-actions Bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

github-actions Bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

duckduckgrayduck commented Apr 7, 2026

Uh oh!

duckduckgrayduck commented Apr 7, 2026

Uh oh!

duckduckgrayduck commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

duckduckgrayduck commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eyeseast commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

duckduckgrayduck commented Apr 7, 2026

Uh oh!

eyeseast commented Apr 7, 2026

Uh oh!

mitchelljkotler left a comment

Choose a reason for hiding this comment

Uh oh!

eyeseast commented Apr 8, 2026

Uh oh!

allanlasser commented Apr 9, 2026

Uh oh!

allanlasser Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

duckduckgrayduck commented Apr 9, 2026

Uh oh!

eyeseast commented Apr 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

allanlasser commented Apr 9, 2026

Uh oh!

allanlasser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

eyeseast commented Mar 31, 2026 •

edited

Loading

github-actions Bot commented Apr 1, 2026 •

edited

Loading

github-actions Bot commented Apr 3, 2026 •

edited

Loading

duckduckgrayduck commented Apr 7, 2026 •

edited

Loading

duckduckgrayduck commented Apr 7, 2026 •

edited

Loading

eyeseast commented Apr 7, 2026 •

edited

Loading