Infrastructure: add retries to brew install to handle hangs#9045
Infrastructure: add retries to brew install to handle hangs#9045vadi2 merged 8 commits intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
| brew install libzzip libzip ccache expect assimp hunspell pcre2 pugixml sqlite yajl boost | ||
| # brew install can hang indefinitely during bottle pouring, so timeout and retry | ||
| for attempt in 1 2 3; do | ||
| if timeout 120 brew install libzzip libzip ccache expect assimp hunspell pcre2 pugixml sqlite yajl boost; then |
There was a problem hiding this comment.
Think we can add --verbose to the install command? It seems to hang just after fetching everything, but we've no idea as to why. Maybe some extra information from verbose will enlighten us?
|
@vadi2 Also, seems 
|
|
@vadi2 And, looks like 
|
Looks like that worked |
|
|
No nevermind, I think the output from --verbose just made things take too long as the system tried to keep up with all the output. |
| for attempt in 1 2 3; do | ||
| brew install libzzip libzip ccache expect assimp hunspell pcre2 pugixml sqlite yajl boost & | ||
| brew_pid=$! | ||
| ( sleep 120 && kill $brew_pid 2>/dev/null ) & |
There was a problem hiding this comment.
So you are waiting for 2 minutes (120 seconds) for the brew install to complete and allowing 10 minutes overall for 3 tries = 2 x 3 = 6 minutes - so isn't there time for 4 tries (if not 5)? 😀
3 participants
Brief overview of PR changes/additions
macOS builds are still hanging, so let's add retries to them in hope that'll bring more resiliency.
Motivation for adding to Mudlet
CI builds we can rely on to work.
Other info (issues closed, discussion etc)