infrastructure: fix Windows PTB registration failing after installer rename#9150
Merged
vadi2 merged 1 commit intodevelopmentfrom Apr 5, 2026
Merged
infrastructure: fix Windows PTB registration failing after installer rename#9150vadi2 merged 1 commit intodevelopmentfrom
vadi2 merged 1 commit intodevelopmentfrom
Conversation
The installer was renamed from *-windows-64.exe to *-windows-64-installer.exe in #9127, but the search pattern in register-windows-release.sh was not updated, causing the PTB registration step to loop for an hour and fail.
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
|
Reviews (1): Last reviewed commit: "Fix: update PTB register search pattern ..." | Re-trigger Greptile |
Member
Author
|
Merging now to iron out the new github releases infrastructure, but reviews are welcome as always for a second pair of eyes. |
vadi2
added a commit
that referenced
this pull request
Apr 5, 2026
…g, and portable ZIP upload (#9154) #### Brief overview of PR changes/additions - Fix macOS Intel PTB updater serving the ARM64 binary instead of x64 (wrong variable in `link-ptbs-to-dblsqd.yml` since PR #7488) - Fix PTB registration search pattern to match both old (`*-windows-64.exe`) and new (`*-windows-64-installer.exe`) naming from make.mudlet.org - Fix portable ZIP upload silently failing on release builds due to undefined `GITHUB_WORKSPACE_UNIX_PATH` in `deploy-mudlet-for-windows.sh` - Fix double curl call per retry in `register-windows-release.sh` and stray `}` in debug echo #### Motivation for adding to Mudlet Multiple CI bugs affecting PTB delivery: Intel Mac users get ARM64 binaries via the updater, Windows PTB registration fails when make.mudlet.org uses the old naming, and portable ZIP never uploads for releases. #### Other info (issues closed, discussion etc) The macOS x64/ARM64 mixup was introduced in #7488. The register pattern issue is a follow-up to #9150. **Test case:** Trigger a PTB build and verify: (1) `register-windows-release.sh` finds the URL regardless of naming, (2) `link-ptbs-to-dblsqd.yml` links the correct macOS x64 URL, (3) a tagged release build attempts the portable ZIP upload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
register-windows-release.shto match the installer filename renamed in Infrastructure: add CI workflow to create GitHub Releases for updater #9127 from*-windows-64.exeto*-windows-64-installer.exeMotivation for adding to Mudlet
The "Register PTB Release" CI step is broken on
development— it can never find the uploaded installer.Other info (issues closed, discussion etc)
Regression from #9127.
Test case: Trigger a scheduled/manual PTB Windows build and verify the "Register PTB Release" step completes successfully.