fixes#25
Merged
Merged
Conversation
will-pang
approved these changes
May 28, 2026
will-pang
left a comment
There was a problem hiding this comment.
didn't test extensively, but I trust John haha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new multimodal embedding runners for MIMIC-IV + CXR using both MLP and JambaEHR architectures, and brings several improvements and standardizations to the Mamba-based runner. The changes improve reproducibility, flexibility, and evaluation reporting for multimodal mortality prediction experiments.
New multimodal runner scripts:
multimodal_embedding_mlp_mimic4_cxr.pyfor running unified multimodal embeddings with an MLP backbone. This script supports EHR, notes, and X-ray metadata/negbio inputs, and includes argument parsing, dataset setup, model instantiation, training, evaluation, and benchmarking.multimodal_embedding_jamba_mimic4_cxr.pyfor running unified multimodal embeddings with a JambaEHR (hybrid Transformer + Mamba) backbone. The script mirrors the structure and features of the MLP runner, supporting flexible configuration and benchmarking.Enhancements and standardization to the Mamba runner:
Evaluation and metrics improvements:
multimodal_embedding_mamba_mimic4_cxr.py) from only"accuracy"to include"pr_auc"and"roc_auc", aligning with the new runner scripts for better model assessment.Argument parsing and reproducibility:
--condorflag to all runner scripts to facilitate setting the device to"cuda"(no index) for HTCondor GPU jobs. [1] [2] [3]1in the Mamba runner for consistency with the new scripts.These updates provide a unified, extensible framework for benchmarking multimodal models on MIMIC-IV with CXR data, and facilitate reproducible experiments across different neural architectures.
References: