Skip to content

Add support for a few meteor skill tree nodes#87

Merged
Musholic merged 2 commits intoMusholic:devfrom
ronoudgenoeg:mod-support
Mar 21, 2026
Merged

Add support for a few meteor skill tree nodes#87
Musholic merged 2 commits intoMusholic:devfrom
ronoudgenoeg:mod-support

Conversation

@ronoudgenoeg
Copy link

@ronoudgenoeg ronoudgenoeg commented Mar 21, 2026

Adds support for:

  • "number of .* for direct casts
  • always crits above x mana

Description of the problem being solved:

The above mods were not supported.

Steps taken to verify a working solution:

  • Pick nodes on Meteor containing these affixes
  • See DPS go up the expected amount

Link to build showing support: https://sharetext.io/ozy5z4je

Before screenshot:

Below mods didn't add anything before fixes.

After screenshot:

image image image image image

@ronoudgenoeg ronoudgenoeg marked this pull request as ready for review March 21, 2026 11:45
@Musholic
Copy link
Owner

Thanks for the contribution, it looks good. If you are willing and comfortable enough, it could help to have a simple automated test similar to this one: https://github.com/Musholic/LastEpochPlanner/blob/dev/spec/System/TestModParse_spec.lua#L133
But I won't be picky with the first external PR, I can merge it as is on Monday after I double check a few things.

@Musholic Musholic changed the title Add support for few new affixes Add support for a few meteor skill tree nodes Mar 21, 2026
@Musholic Musholic added the enhancement New feature or request label Mar 21, 2026
@Musholic
Copy link
Owner

Thanks for the automated test, I guess the generalisation of "number of (%a[%a ]*) for direct casts" was not strictly necessary since it's a skill tree node (and thus does only apply to the meteor skill in this case) but it makes sense to do it so I'm fine with it.

@Musholic Musholic merged commit 6a286ac into Musholic:dev Mar 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants