fix(i18n): resolve 48 t() calls referencing missing EN locale keys - #329
Merged
Conversation
Stem had 48 t() call sites referencing keys that didn't exist in the EN locale JSON. i18next's fallback semantics (second arg to t()) showed the key as English text so users didn't see broken UI — but ES translations never resolved, leaving the Spanish version permanently showing English for these labels. Surfaced by check-keys.py landing via PR #327; cleanup of the backlog so the --ratchet flag can eventually be dropped from CI. Two-pronged fix: (1) Namespace prefix corrections (24 call sites) — keys actually exist in settings.json but t() calls referenced them via the default common namespace. Fixed by changing literal call sites to use the settings: cross-namespace prefix: t('settings.interface.title', 'Interface') → t('settings:interface.title', 'Interface') Affected: SettingsDrawer, HeaderInterfaceSelector, InterfaceSection, ModeSection, ReflectorSection, RFC2544Section, RFC2889Section, RFC6349Section, Y1564Section, Y1731Section, MEFSection, TrafficGenSection, TSNSection. (2) Missing keys added to locale JSON (24 keys + ES translations): common.json: - accessibility.{closeSettings, openHistory, refreshInterfaces, selectProfile} - interface.{networkInterfaces, noInterfaces, select} - profile.{current, manage, noProfiles, select} - tooltips.header.{refresh, history, help, settings, logout} - status.{clickToReconnect, tapToReconnect, tapToReconnectHint} settings.json: - viewModuleHint, viewStandardHint - tests.{rfc2544, rfc2889, rfc6349, y1564, y1731, mef, trafficgen, tsn}.title (8 test category headings) setup.json: - buttons.copyTooltip ES translations follow I18N_TRANSLATION_MEMORY.md (formal usted, sentence case, glossary terms preserved verbatim — Reflector, MEF, RFC numbers, Y.1564 etc. stay English). Validation: tsc clean; biome clean; vitest 136 passed; check-keys strict mode now passes (was 48 errors, now 0); validator strict still fails on the pre-existing 355 fallback-pattern check (separate cleanup) and i18next 26.2 → 26.3 version bump (PR #317). Drop the --ratchet flag from .github/workflows/ci.yml's check_key_usage invocation in a separate PR once the related fallback-pattern cleanup also lands.
krisarmstrong
enabled auto-merge (squash)
May 27, 2026 14:45
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Contributor
License Compliance ReportAll dependencies pass license compliance checksGo Dependencies
npm DependenciesSee full report in workflow artifacts Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0 |
This was referenced May 27, 2026
Merged
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stem had 48 t() call sites referencing keys that didn't exist in
the EN locale JSON. i18next's fallback semantics (second arg to
`t()`) showed the key as English text so users didn't see broken
UI — but ES translations never resolved, leaving the Spanish
version permanently showing English for these labels.
Surfaced by `check-keys.py` landing via PR #327; cleanup of the
backlog so the `--ratchet` flag can eventually be dropped from CI.
Two-pronged fix
(1) Namespace prefix corrections (24 call sites)
Keys actually exist in `settings.json` but t() calls referenced them
via the default `common` namespace. Fixed by changing literal call
sites to use the `settings:` cross-namespace prefix:
```diff
-t('settings.interface.title', 'Interface')
+t('settings:interface.title', 'Interface')
```
Affected: SettingsDrawer, HeaderInterfaceSelector, InterfaceSection,
ModeSection, ReflectorSection, RFC2544Section, RFC2889Section,
RFC6349Section, Y1564Section, Y1731Section, MEFSection,
TrafficGenSection, TSNSection.
(2) Missing keys added to locale JSON (24 new keys + ES)
common.json:
settings.json:
(8 test category headings)
setup.json:
ES translations follow `I18N_TRANSLATION_MEMORY.md` (formal `usted`,
sentence case, glossary terms preserved verbatim — Reflector, MEF,
RFC numbers, Y.1564 etc. stay English).
Test plan
(pre-existing fallback patterns + heuristic JSX flags + version
pin)
Follow-up
about are a separate concern (task Docs mismatch: Implementation spec module paths differ from code layout #45 sibling).
`.github/workflows/ci.yml`'s `check_key_usage` invocation in a
separate PR once the fallback-pattern cleanup also lands.
get the same fix in a sibling PR.