chore(i18n): promote check-keys.py unused-key check from warn to fail - #337
Merged
Conversation
All 3 products now hit 0 unused EN locale keys via the per-repo dynamic-prefixes.txt allowlists (niac-go#732 + stem#335 + seed#1216). Promoting the unused-key check from warn-only to fail so future cruft gets caught at PR time. To allow a genuinely dynamic-lookup key that the static analyzer can't see, add a prefix entry to scripts/i18n/dynamic-prefixes.txt with a one-line WHY comment. --ratchet downgrades the check back to warn for callers that want to defer cleanup (the validator passes --ratchet through).
krisarmstrong
enabled auto-merge (squash)
May 27, 2026 16:05
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Contributor
License Compliance ReportAll dependencies pass license compliance checksGo Dependencies
npm DependenciesSee full report in workflow artifacts Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All 3 products now hit 0 unused EN locale keys via the per-repo
dynamic-prefixes.txtallowlists (niac-go#732 + stem#335 +seed#1216). Promoting the unused-key check from warn-only to fail
so future cruft gets caught at PR time.
How to fix a new "unused" failure
If a key shows up as unused but is genuinely consumed via a
dynamic lookup the static analyzer can't see, add a prefix entry
to
scripts/i18n/dynamic-prefixes.txtwith a one-line WHYcomment:
If a key is genuinely dead, delete it from EN+ES locale JSON.
Escape hatch
--ratchetdowngrades the check back to warn for callers thatwant to defer cleanup. The shared validator passes
--ratchetthrough, so CI invocations using
./scripts/i18n/validate.sh --ratchetstill get the lenient behaviour.Test plan
python3 scripts/i18n/check-keys.pystrict — exits 0i18n Validationjob