feat(ui): converge settings drawer shell (Phase 3c) - #353
Merged
Conversation
Aligns stem's settings drawer with the seed/niac shells (each repo owns its own copy; no master): switch the dialog from aria-label to aria-labelledby pointing at an id'd <h2 id="settings-drawer-title">, add the canonical data-testid pair (settings-drawer / settings-drawer-close), and add the animate-slide-in entrance. Already used useFocusTrap.
krisarmstrong
enabled auto-merge (squash)
May 28, 2026 22:15
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Contributor
License Compliance ReportAll dependencies pass license compliance checksGo Dependencies
npm DependenciesSee full report in workflow artifacts Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0 |
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 3c — converge the settings drawer shell across seed/stem/niac (each owns its own copy; no master). stem:
aria-label→aria-labelledbypointing at an id'd<h2 id="settings-drawer-title">, add canonical testids (settings-drawer/settings-drawer-close), addanimate-slide-in. Already useduseFocusTrap. tsc + biome clean.