refactor(ui): extract stem help drawer into components + i18n chrome (#44) - #355
Merged
Merged
Conversation
…ome (#44) Converges stem's help drawer toward niac's structure (each repo owns its own copy; no master) without changing behavior. - Extract the inline detail/tab JSX (~530 lines) out of HelpDrawer.tsx into ui/src/components/help-drawer/: TestsTab, TestCard, TestDetailView, TutorialsTab, TutorialDetailView, GlossaryTab, CopyCommandButton. HelpDrawer.tsx shrinks from ~818 to ~290 lines (pure orchestration). - Add a `help` i18n namespace (en + es) for the drawer CHROME — tab/section labels, headings, search placeholder, close/back buttons, simple/technical toggle, intros — and route them through useTranslation('help'). The help CONTENT corpus (test descriptions/glossary/tutorial bodies) stays in the data file (out of scope). - Add ui/e2e/help-drawer-smoke.spec.ts (open → content → switch tab → close via the help-drawer testids). Verified locally: tsc / biome / build / token-discipline clean; i18n unit tests 9/9; the help e2e specs (existing + new smoke) 5/5 pass against stem web on :8444.
krisarmstrong
enabled auto-merge (squash)
May 28, 2026 23:38
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Contributor
License Compliance ReportAll dependencies pass license compliance checksGo Dependencies
npm DependenciesSee full report in workflow artifacts Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final harmonization follow-up — converge stem's help drawer toward niac's structure (each repo owns its own copy; no master), no behavior change.
HelpDrawer.tsxintoui/src/components/help-drawer/:TestsTab,TestCard,TestDetailView,TutorialsTab,TutorialDetailView,GlossaryTab,CopyCommandButton.HelpDrawer.tsxdrops from ~818 → ~290 lines (pure orchestration).helpnamespace (en + es): tab/section labels, headings, search placeholder, close/back, simple/technical toggle, intros, viauseTranslation('help'). The help content corpus (test descriptions/glossary/tutorials) stays in the data file (separate localization effort).help-drawer-smoke.spec.ts(open → content → tab switch → close via testids).Test plan
tsc/ biome /npm run build/ token-discipline clean; i18n unit tests 9/9help-drawer.spec+ new smoke) 5/5 pass locally vsstem webon :8444