chore(security): add output-escaping/XSS regression gate (#343) - #359
Merged
Conversation
Audit (2026-05-28): classified all 93 fmt.Fprintf(w, ...) sites.
90 are CLI help display (internal/help, ANSI → stdout); 3 are literal
SSE comment lines in internal/api (": heartbeat\n\n" etc., no format
verbs). Zero sites render user data as HTML. No code fix needed.
Adds scripts/check-output-escaping.sh + CI wiring to prevent
regressions:
- fails if raw innerHTML injection appears in ui/src app code
- fails if a value-interpolating fmt.Fprintf(w, "...%s...") is added
in internal/api (HTTP responses must use the JSON encoder or
html/template; literal SSE comments don't match)
Modeled on the existing scripts/check-token-discipline.sh gate.
Currently passes clean.
Closes #343.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
krisarmstrong
enabled auto-merge (squash)
May 29, 2026 00:36
Contributor
License Compliance ReportAll dependencies pass license compliance checksGo Dependencies
npm DependenciesSee full report in workflow artifacts Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit (2026-05-28): classified all 93 fmt.Fprintf(w, ...) sites.
90 are CLI help display (internal/help, ANSI → stdout); 3 are literal
SSE comment lines in internal/api (": heartbeat\n\n" etc., no format
verbs). Zero sites render user data as HTML. No code fix needed.
Adds scripts/check-output-escaping.sh + CI wiring to prevent
regressions:
in internal/api (HTTP responses must use the JSON encoder or
html/template; literal SSE comments don't match)
Modeled on the existing scripts/check-token-discipline.sh gate.
Currently passes clean.
Closes #343.