feat(a11y): axe-core test harness for the Button primitives - #370
Merged
Conversation
Mirrors the seed harness (each repo owns its own copy — no master). Adds axe-core (4.11.4) and ui/src/test/a11y.ts (runAxe + expectNoAxeViolations) so components can be paired with an a11y test that catches button-name, image-alt, label, and other WCAG rules no static lint detects. Button.a11y.test.tsx exercises every Button + IconButton variant and tone (29 renders) against axe-core. The wider stem icon-button surface was audited and found to already carry aria-label where needed (Sidebar mobile-overlay, CommandPalette scrim, etc.); the conversion sweep the plan anticipated isn't required. Establishes the gate for future regressions.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Contributor
License Compliance ReportAll dependencies pass license compliance checksGo Dependencies
npm DependenciesSee full report in workflow artifacts Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the seed harness (each repo owns its own copy — no master). Adds
axe-core (4.11.4) and ui/src/test/a11y.ts (runAxe + expectNoAxeViolations)
so components can be paired with an a11y test that catches button-name,
image-alt, label, and other WCAG rules no static lint detects.
Button.a11y.test.tsx exercises every Button + IconButton variant and tone
(29 renders) against axe-core. The wider stem icon-button surface was
audited and found to already carry aria-label where needed (Sidebar
mobile-overlay, CommandPalette scrim, etc.); the conversion sweep the
plan anticipated isn't required. Establishes the gate for future
regressions.