fix(ui): drop sidebar-*-button testids on the mobile aside copy - #381
Merged
Conversation
stem CI on the post-#380 main run failed with strict-mode violations on every E2E test that calls page.getByTestId('sidebar-help-button'), page.getByTestId('sidebar-history-button'), or page.getByTestId( 'sidebar-settings-button') — each resolving to 2 elements. Root cause: SidebarLayout mounts SidebarBody twice as two aside-wrapped copies of the same `body` element — a mobile copy (`lg:hidden`) and a desktop copy (`hidden lg:flex`). The responsive classes only toggle CSS display, not React mount, so both copies live in the DOM regardless of viewport. SidebarFooter inside that body emits five sidebar-*-button testids; every one of them therefore appears twice in the DOM. Fix: thread a `surfaceTestIds: boolean` through SidebarBody → SidebarFooter. The mobile aside receives `body(false)`, the desktop aside receives `body(true)`. Mobile copies drop the sidebar-*-button data-testid attributes; desktop copies keep them. Playwright's default 1280x720 viewport lands on the desktop aside, so existing specs (auth, help-drawer, result-history, smoke) work unchanged. This is a UI-side fix rather than a test-side `.locator(':visible')` workaround because: - The duplication is a UI bug that existed before E2E touched it (the mobile-and-desktop dual-mount predates testid migration). - Filtering by `:visible` in every spec would mask future genuine dup-testid mistakes elsewhere in the app. - Strict-mode is a feature we want to keep on, not work around. No spec changes — the existing `getByTestId('sidebar-help-button')` lookups now resolve to exactly one element. The previous "all E2E Browser Tests pass" runs (before merge of #377/#378/#379) were coincidental: those PRs added the testids without yet triggering the dup; the smoke rewrite in #380 added more lookups, which surfaced the strict-mode violation. A follow-up will audit whether seed/niac sidebars have the same dual-mount pattern (likely yes for seed since the layout shape is shared); fixes there will land separately.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Contributor
License Compliance ReportAll dependencies pass license compliance checksGo Dependencies
npm DependenciesSee full report in workflow artifacts Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stem CI on the post-#380 main run failed with strict-mode violations
on every E2E test that calls page.getByTestId('sidebar-help-button'),
page.getByTestId('sidebar-history-button'), or page.getByTestId(
'sidebar-settings-button') — each resolving to 2 elements.
Root cause: SidebarLayout mounts SidebarBody twice as two
aside-wrapped copies of the same
bodyelement — a mobile copy(
lg:hidden) and a desktop copy (hidden lg:flex). Theresponsive classes only toggle CSS display, not React mount, so
both copies live in the DOM regardless of viewport. SidebarFooter
inside that body emits five sidebar-*-button testids; every one of
them therefore appears twice in the DOM.
Fix: thread a
surfaceTestIds: booleanthrough SidebarBody →SidebarFooter. The mobile aside receives
body(false), thedesktop aside receives
body(true). Mobile copies drop thesidebar-*-button data-testid attributes; desktop copies keep them.
Playwright's default 1280x720 viewport lands on the desktop aside,
so existing specs (auth, help-drawer, result-history, smoke) work
unchanged.
This is a UI-side fix rather than a test-side
.locator(':visible')workaround because:
(the mobile-and-desktop dual-mount predates testid migration).
:visiblein every spec would mask future genuinedup-testid mistakes elsewhere in the app.
No spec changes — the existing
getByTestId('sidebar-help-button')lookups now resolve to exactly one element. The previous "all
E2E Browser Tests pass" runs (before merge of #377/#378/#379)
were coincidental: those PRs added the testids without yet
triggering the dup; the smoke rewrite in #380 added more lookups,
which surfaced the strict-mode violation.
A follow-up will audit whether seed/niac sidebars have the same
dual-mount pattern (likely yes for seed since the layout shape is
shared); fixes there will land separately.