chore: bump Go 1.26.4 (GO-2026-5037/5039) + gitleaks/e2e CI cleanup - #397
Merged
Conversation
added 3 commits
May 30, 2026 17:54
stem CI on the post-#387 main run (#26695591706) failed in reflector-platform-guard.spec.ts:46: await expect(page.getByTestId('role-chip-test-master')) .toBeVisible(); The actual testid emitted by RoleChip.tsx:115 is `role-chip-${option.id}`, and option.id for the Test Master role is `test_master` (underscore, see RoleChip.tsx:39). My #387 migration used `role-chip-test-master` (hyphen), so the locator resolved to zero elements and the test failed deterministically on both chromium and webkit. Fix: one-character change, hyphen -> underscore. Brings the spec in line with the actual id key.
A workflow_dispatch CI run on stem main (#26697916907) failed the
Security Scanning job. Gitleaks's hardcoded-password rule flagged
tests/smoke/run_smoke_tests.sh:52:
: "${STEM_AUTH_PASSWORD:=$(openssl rand -base64 18)}"
False positive — the right-hand side is a dynamic `openssl rand`
call, not a literal password value. Push-event CI runs only diff
the latest commit and never tripped on this; workflow_dispatch
re-scans the full git history (the leaking commit is 6f34d6f from
the C-dataplane-fallback work, before gitleaks was tuned for this
project), so it surfaces every historical hit.
Added an inline `# gitleaks:allow` annotation on the line itself
plus a comment block above explaining why future scans should
ignore it. Gitleaks honors `gitleaks:allow` in any commit it sees,
so the historical commit is dispatched-scan-safe too.
krisarmstrong
enabled auto-merge (squash)
June 7, 2026 02:44
Contributor
License Compliance ReportAll dependencies pass license compliance checksGo Dependencies
npm DependenciesSee full report in workflow artifacts Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0 |
govulncheck flags crypto/x509.Certificate.Verify (GO-2026-5037) and net/textproto.Reader.ReadMIMEHeader (GO-2026-5039) on 1.26.3. seed already bumped (#1469); stem follows per CLAUDE.md.
Contributor
License Compliance ReportAll dependencies pass license compliance checksGo Dependencies
npm DependenciesSee full report in workflow artifacts Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0 |
krisarmstrong
changed the title
gitleaks-action now requires a paid licence for org repos ([MustardSeedNetworks] is an organization). Swap to the MIT-licensed gitleaks CLI (pinned 8.30.0 + SHA-256), matching seed #1552. Unblocks the Security Scanning job.
Contributor
License Compliance ReportAll dependencies pass license compliance checksGo Dependencies
npm DependenciesSee full report in workflow artifacts Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0 |
Full-history gitleaks CLI scan flags the throwaway smoke-test password in tests/smoke/run_smoke_tests.sh (a created-then-deleted test user, not a real secret). Inline gitleaks:allow can't suppress historical commits, so allowlist the path.
Contributor
License Compliance ReportAll dependencies pass license compliance checksGo Dependencies
npm DependenciesSee full report in workflow artifacts Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the in-flight stem branch ahead of the module-path rename (staged sequence).
Headline (unblocks CI): bump
go 1.26.3→1.26.4—govulncheck(hard gate) flags crypto/x509 (GO-2026-5037) + net/textproto (GO-2026-5039) stdlib CVEs on 1.26.3. seed already did this in #1469; stem follows per CLAUDE.md.Also folded in (the original branch work):
STEM_AUTH_PASSWORDtest value asgitleaks:allowrole-chip-test_masterunderscore fix; format language-layout sanity testNo production-code changes beyond the toolchain bump.