refactor(services): rename 'package modules' -> 'services' (dir == package) - #403
Merged
Merged
Conversation
…irectory internal/services/ declared 'package modules' — a half-finished rename that forced every caller to alias the import (modules "...internal/services"). Rename the package to 'services' so directory == package name, and drop the aliases at the 4 call sites (handlers_modules, handlers_testing, cmd/stem/main, help/display + the external module_test). Also corrected the package doc comment (was 'Package modules', referenced the phantom 'testmaster' subsystem -> orchestrator). Mechanical; build + vet + lint(0) + services/help/cmd/api-module tests green. Phase 2 architecture coherence.
krisarmstrong
enabled auto-merge (squash)
June 8, 2026 03:01
Contributor
License Compliance ReportAll dependencies pass license compliance checksGo Dependencies
npm DependenciesSee full report in workflow artifacts Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 coherence.
internal/services/declaredpackage modules— a half-finished rename that left directory ≠ package and forced every caller to alias the import (modules "…/internal/services"). Renamed the package toservicesso directory == package, dropped the aliases at the 4 call sites + the external test, and fixed the stale package doc comment (Package modules, phantomtestmaster→orchestrator).Mechanical, behavior-preserving:
go build+go vetclean, golangci 0 issues, services/help/cmd + api module-handler tests green. No overlap with the in-flight #401 registry (different files).