Skip to content

fix(ui): i18n the Account nav group label (S3) - #419

Merged
krisarmstrong merged 2 commits into
mainfrom
fix/account-nav-i18n-key
Jun 14, 2026
Merged

fix(ui): i18n the Account nav group label (S3)#419
krisarmstrong merged 2 commits into
mainfrom
fix/account-nav-i18n-key

Conversation

@krisarmstrong

Copy link
Copy Markdown
Collaborator

Quick win from STEM_UI_ARCH_PLAN.md.

The Account sidebar group label was a bare English string literal, so it never translated — every other group uses '' (headerless) or a common:sections.* i18n key. Add common.sections.account (en: Account / es: Cuenta) and reference it via common:sections.account. The Security item label stays verbatim (standard term).

Note: the two headerless groups (Reflector, History) are deliberate (documented in navGroups.ts; singleton Mode group removed in #66) and left as-is — adding single-item headers would reintroduce the exact noise seed's nav reform removed. This PR fixes only the genuine i18n defect.

Verification

  • tsc --noEmit clean; Biome clean (incl. JSON).
  • en/es sections parity preserved; i18n parity + navGroups tests green (29 passed).

The 'Account' sidebar group used a bare string literal, so it never
translated — every other group uses '' or a common:sections.* key. Add
common.sections.account (en: Account / es: Cuenta) and reference it. The
'Security' item label stays as-is (product/standard term).

tsc + biome clean; i18n parity + navGroups tests green (29).
@krisarmstrong
krisarmstrong enabled auto-merge (squash) June 14, 2026 16:12
@github-actions

Copy link
Copy Markdown
Contributor

License Compliance Report

All dependencies pass license compliance checks

Go Dependencies

  • Unknown: 31 package(s)
  • MIT: 26 package(s)
  • BSD-3-Clause: 16 package(s)
  • Apache-2.0: 11 package(s)
  • BSD-2-Clause: 1 package(s)

npm Dependencies

See full report in workflow artifacts

Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0
Forbidden: GPL, AGPL, SSPL (strong copyleft)

@github-actions

Copy link
Copy Markdown
Contributor

License Compliance Report

All dependencies pass license compliance checks

Go Dependencies

  • Unknown: 31 package(s)
  • MIT: 26 package(s)
  • BSD-3-Clause: 16 package(s)
  • Apache-2.0: 11 package(s)
  • BSD-2-Clause: 1 package(s)

npm Dependencies

See full report in workflow artifacts

Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0
Forbidden: GPL, AGPL, SSPL (strong copyleft)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant