refactor(ui): unify HeaderBar icons to lucide-react (S4/S8) - #428
Merged
Conversation
Replace 12 hand-rolled inline SVG icon components with lucide-react equivalents (already stem's icon system in navGroups/Sidebar/pageRegistry), and remove the 4 @deprecated, ignored props. Icon map: Activity→Activity, Wifi→Wifi, WifiOff→WifiOff, Sun→Sun, Moon→Moon, Refresh→RefreshCw, Settings→Settings, Logout→LogOut, User→User, Ethernet→EthernetPort, Check→Check, Spinner→Loader2. Connection-status color logic + animate-pulse/animate-spin behavior preserved at each call site. Removed onRefresh/onHistoryOpen/onHelpOpen/ onSettingsOpen (no callers passed them). HeaderBar.tsx: 809 → 592 lines. 0 inline <svg>. tsc + biome clean; 29 HeaderBar tests pass; build green.
krisarmstrong
enabled auto-merge (squash)
June 15, 2026 14:07
Contributor
License Compliance ReportAll dependencies pass license compliance checksGo Dependencies
npm DependenciesSee full report in workflow artifacts Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace 12 inline-SVG icons with lucide-react (Activity/Wifi/WifiOff/Sun/Moon/RefreshCw/Settings/LogOut/User/EthernetPort/Check/Loader2); remove 4 @deprecated ignored props (no callers). Connection-status color + animate-pulse/spin preserved. HeaderBar 809→592 lines, 0 inline svg, no new dep. tsc/biome clean, 29/29 tests, build green. Mirrors seed #1582 (S4/S8).