Skip to content

fix(release): use root release-please manifest - #502

Merged
krisarmstrong merged 1 commit into
mainfrom
fix/stem-root-release-manifest
Jul 9, 2026
Merged

fix(release): use root release-please manifest#502
krisarmstrong merged 1 commit into
mainfrom
fix/stem-root-release-manifest

Conversation

@krisarmstrong

@krisarmstrong krisarmstrong commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds root .release-please-manifest.json at the latest valid Stem release, 0.23.0
  • Updates release-please.yml to use the root manifest path that the action actually fetched in run 28989570268
  • Prevents release-please from falling back to invalid merged 1.x release PR history

Linked Issue

Related to #497

Testing Evidence

gh pr close 501 --repo MustardSeedNetworks/stem
Closed pull request MustardSeedNetworks/stem#501 (chore(main): release 2.0.0)

gh release view v1.0.0 --repo MustardSeedNetworks/stem --json tagName,url,createdAt,publishedAt,targetCommitish
release not found

git ls-remote --tags https://github.com/MustardSeedNetworks/stem.git refs/tags/v2.0.0 refs/tags/v1.0.0 refs/tags/v1.0.1 refs/tags/v0.23.0
2b64395476c3edfee4b5e1421c61ac6ec5cff59b refs/tags/v0.23.0

release-please run 28989570268 log:
Fetching .release-please-manifest.json from branch main
file .release-please-manifest.json did not exist

Security and Release Checklist

  • Closed invalid Stem 2.0.0 release PR chore(main): release 2.0.0 #501
  • Confirmed erroneous Stem v1.0.0 release is absent
  • Confirmed erroneous Stem v1.0.0/v1.0.1/v2.0.0 tags are absent
  • Confirmed valid latest Stem release tag is v0.23.0
  • No product code or dependency changes

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

License Compliance Report

All dependencies pass license compliance checks

Go Dependencies

  • Unknown: 35 package(s)
  • MIT: 25 package(s)
  • BSD-3-Clause: 16 package(s)
  • Apache-2.0: 11 package(s)
  • BSD-2-Clause: 1 package(s)

npm Dependencies

See full report in workflow artifacts

Allowed Licenses: MIT, Apache-2.0, BSD-*, ISC, CC0-1.0, MPL-2.0
Forbidden: GPL, AGPL, SSPL (strong copyleft)

@krisarmstrong
krisarmstrong merged commit 1f5ff94 into main Jul 9, 2026
28 checks passed
@krisarmstrong
krisarmstrong deleted the fix/stem-root-release-manifest branch July 9, 2026 02:43
This was referenced Jul 9, 2026
Closed
Closed
Closed
Closed
Merged
krisarmstrong added a commit that referenced this pull request Jul 10, 2026
@krisarmstrong
fix(release): correct release-please config nesting (kill the 2.0.0) (#…
0c315c5 
…512)

Codex placed 'release-as' and 'last-release-sha' at the TOP LEVEL of
release-please-config.json, where release-please ignores them (they must
live inside packages['.']). So its intended 'force 0.24.0' did nothing and
release-please kept computing off the reverted #497 (1.0.0) release PR,
proposing 2.0.0. Also removes the duplicate root manifest codex added
(#502) and points the workflow at the standard .github manifest.

- move release-as: 0.24.0 into packages['.']
- drop ignored top-level last-release-sha + release-as
- manifest-file -> .github/.release-please-manifest.json; delete root dup

After 0.24.0 ships, release-as should be removed (follow-up) so future
releases compute from 0.24.0 (which supersedes the phantom 1.0.0).
This was referenced Jul 10, 2026
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci config

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@krisarmstrong