Make the planner suite hermetic against CI's unattended env - #1
Merged
Conversation
The happy-path test asserted the tracking issue always gets edited, which only holds in an attended shell. Under CI (GITHUB_ACTIONS=true) the planner correctly fail-closes: the `tracking-issue-edit` ASK collapses to DENY when unattended, so the public edit is suppressed — the harness's stance on public content. The test was inheriting the runner's env and failing. - conftest: autouse fixture unsets GITHUB_ACTIONS so the suite defaults to the attended path deliberately, not by accident of where it runs. - add a test locking the unattended-suppression behavior: the plan is still computed and recorded, but no public issue edit is made. Tool behavior unchanged; this is a test-hermeticity fix. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The genesis
mainwent red in CI while passing locally. Root cause: thehappy-path test asserted the tracking issue always gets edited, but that only
holds in an attended shell. Under CI (
GITHUB_ACTIONS=true) the plannercorrectly fail-closes — the
tracking-issue-editASK collapses to DENY whenunattended, so the public edit is suppressed (the harness's stance on public
content). The test was inheriting the runner's env.
conftest: autouse fixture unsetsGITHUB_ACTIONSso the suite defaults tothe attended path deliberately.
public issue edit.
Tool behavior unchanged — test-hermeticity only. Green with
GITHUB_ACTIONS=truelocally.🤖 Generated with Claude Code