Wire Guard into the default policy so ASK actually escalates - #8
Merged
Conversation
DefaultPolicy implemented mythings.policy.Policy directly and never consulted MYTHINGS_ASK_CMD, so every unattended run's tracking-issue ASK collapsed straight to DENY regardless of whether a human was reachable. Route the same rule through myguard.Guard instead. Refs MyThingsLab/fleet-dispatch#40 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Same pattern as my-things-core: my-guard is a sibling repo dependency. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultPolicyimplementedmythings.policy.Policydirectly and never readMYTHINGS_ASK_CMD— every unattended run's tracking-issue-edit ASK collapsed straight to DENY via.under(unattended=True), with no escalation step in between (same class of bug my-guard#10 fixed for the bot).default_policy(), amyguard.Guardcarrying the same single rule, so an ASK now escalates through the ask channel before.under()ever runs.my-guardas a dependency.MYTHINGS_ASK_CMDset to an exit-0 command, the tracking-issue edit now happens even underGITHUB_ACTIONS=true.Test plan
python -m pytest -q— 11/11 pass (10 existing + 1 new proof case)ruff check .cleantest_unattended_ci_suppresses_public_issue_editstill passes (no ask channel configured → still fails closed)Refs MyThingsLab/fleet-dispatch#40