Add an images field to Slide, sourced deterministically not by the Engine - #7
Merged
Conversation
…gine Closes #6 Slide.images threads through the same places bullets already goes (_parse_reply, the MyTypster payload, the issue-comment outline). Image paths are never Engine-invented: the model can only choose from an "images:" directive in the issue body (parsed the same deterministic way target_slides already is) or a --images CLI override, and any path in its reply that isn't in that list is silently dropped, never trusted. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slide.images: list[str]threads through the same placesbulletsalready goes:_parse_reply, the MyTypster JSON payload in_call_typster, and the issue-comment outline (_render_outline).images:directive in the issue body (parsed the same deterministic, pre-Engine waytarget_slides/_parse_targetalready is) or a--imagesCLI override. Any path in the Engine's reply that isn't in that available-images list is silently dropped in_parse_reply, never trusted.imagesinto the actual.typ/PDF and staging the file into the PR).Test plan
pytest(10 passing, incl. 2 new: unlisted-path filtering,images:body directive parsing)ruff checkcleanGITHUB_ACTIONS=true pytest🤖 Generated with Claude Code