Clean up ENG-1405 follow-ups#150
Merged
Merged
Conversation
Aaron1924
approved these changes
May 14, 2026
There was a problem hiding this comment.
Pull request overview
This PR cleans up follow-ups around server wallet routing, Enoki fallback behavior, and responsive UI layout for landing/dashboard pages.
Changes:
- Restores round-robin wallet key selection and updates related server comments/tests/logging.
- Makes Enoki direct-sign fallback default to disabled and documents the environment variable.
- Refactors landing/dashboard CTA and navigation styling for responsive layouts.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
services/server/src/types.rs |
Adds atomic cursor-based round-robin behavior to KeyPool and updates tests. |
services/server/src/routes/mod.rs |
Updates wallet job enqueue documentation for execution-time wallet selection. |
services/server/src/main.rs |
Updates startup logging/comments for round-robin wallet pool behavior. |
services/server/src/jobs.rs |
Reassigns upload jobs to a fresh wallet at execution and updates error classification/docs. |
services/server/scripts/sidecar-server.ts |
Defaults Enoki direct-sign fallback to disabled and gates missing-key fallback. |
services/server/.env.example |
Documents ENOKI_FALLBACK_TO_DIRECT_SIGN=false. |
docs/reference/environment-variables.md |
Adds Enoki fallback documentation and wallet pool routing notes. |
apps/app/src/pages/LandingPage.tsx |
Adds login-specific classes for landing page login dropdown styling. |
apps/app/src/pages/Dashboard.tsx |
Moves dashboard CTA/header action layout from inline styles to CSS classes. |
apps/app/src/index.css |
Adds responsive landing/dashboard navigation, CTA, and action layout styles. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const ENOKI_FALLBACK_TO_DIRECT_SIGN = (() => { | ||
| const raw = (process.env.ENOKI_FALLBACK_TO_DIRECT_SIGN || "true").trim().toLowerCase(); | ||
| const raw = (process.env.ENOKI_FALLBACK_TO_DIRECT_SIGN || "false").trim().toLowerCase(); | ||
| return raw !== "0" && raw !== "false" && raw !== "no"; |
Comment on lines
282
to
+285
| tracing::warn!( | ||
| target: "wallet_job.permanent", | ||
| "permanent failure for wallet_index={} (will mark Dead): {}", | ||
| wallet_index, | ||
| enqueued_wallet_index, |
Comment on lines
+232
to
+238
| let wallet_index = state.key_pool.next_index().ok_or_else(|| { | ||
| WalletJobError::Permanent( | ||
| "No Sui keys configured (set SERVER_SUI_PRIVATE_KEYS or SERVER_SUI_PRIVATE_KEY)" | ||
| .into(), | ||
| ) | ||
| .into_apalis_error() | ||
| })?; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests