Skip to content

fix(app): distinguish delete tabs#466

Merged
daniellam258 merged 1 commit into
stagingfrom
fix/delete-ui
Jul 14, 2026
Merged

fix(app): distinguish delete tabs#466
daniellam258 merged 1 commit into
stagingfrom
fix/delete-ui

Conversation

@daniellam258

Copy link
Copy Markdown
Collaborator

Summary

  • explicitly style inactive delete-memory tabs with a black background and white text
  • keep the selected tab white with black text
  • assert that the selected tab state flips correctly when switching tabs

Root cause

The first fix defined only the selected style. The inactive tab still inherited a white background from the broader button styling, so both tabs appeared selected.

Impact

Only the active tab is now visually highlighted, making the current delete-memory view clear.

Validation

  • pnpm --filter @memwal/app test -- src/components/SecurityDeleteSection.test.tsx
  • targeted ESLint check for SecurityDeleteSection.test.tsx
  • git diff --check

@daniellam258
daniellam258 marked this pull request as ready for review July 14, 2026 21:52
@hungtranphamminh
hungtranphamminh self-requested a review July 14, 2026 21:52
@daniellam258
daniellam258 merged commit bec7db1 into staging Jul 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants