Skip to content

Update Integration test to account for the refactoring of the ancestry management#474

Merged
tloubrieu-jpl merged 3 commits into
developfrom
edunn-fixes
Feb 5, 2026
Merged

Update Integration test to account for the refactoring of the ancestry management#474
tloubrieu-jpl merged 3 commits into
developfrom
edunn-fixes

Conversation

@alexdunnjpl

@alexdunnjpl alexdunnjpl commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

🗒️ Summary

Remove tests for second-order ancestry API endpoints, as these are deprecated.

members/members and member-of/member-of URLs are not supported anymore.

⚙️ Test Data and/or Report

Tested with pending bleeding-edge API/ sweepers

♻️ Related Issues

NASA-PDS/registry-api#722
NASA-PDS/registry-sweepers#204

🤓 Reviewer Checklist

Reviewers: Please verify the following before approving this pull request.

Security & Quality

  • SonarCloud: Confirmed no new High or Critical security findings.
  • Secrets Detection: Verified that the Secrets Detection scan passed and no sensitive information (keys, tokens, PII) is exposed.
  • Code Quality: Code follows organization style guidelines and best practices for the specific language (e.g., PEP 8, Google Java Style).

Testing & Validation

  • Test Accuracy: Verified that test data is accurate, representative of real-world PDS4 scenarios, and sufficient for the logic being tested.
  • Coverage: Automated tests cover new logic and edge cases.
  • Local Verification: (If applicable) Successfully built and ran the changes in a local or staging environment.

Documentation

  • Documentation: README, Wiki, or inline documentation (Sphinx, Javadoc, Docstrings) have been updated to reflect these changes.

Maintenance

  • Issue Traceability: The PR is linked to a valid GitHub Issue or Jira Ticket.
  • Backward Compatibility: Confirmed that these changes do not break existing downstream dependencies or API contracts (or that breaking changes are clearly documented).

@nutjob4life nutjob4life left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Py Tests: ✓
Tox: ✓
Approval: ✅
Details:

  py313: OK (3.12=setup[1.25]+cmd[1.87] seconds)
  docs: OK (1.18=setup[0.49]+cmd[0.69] seconds)
  lint: OK (2.96=setup[0.01]+cmd[2.96] seconds)
  congratulations :) (7.41 seconds)

@tloubrieu-jpl tloubrieu-jpl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexdunnjpl , I manually checked that the new test suite work with the PRs:

And that the updated tests are compliant with the changes requested for the ticket NASA-PDS/registry-api#698

@tloubrieu-jpl tloubrieu-jpl changed the title Edunn fixes Update Integration test to account for the refactoring of the ancestry management Feb 5, 2026
@tloubrieu-jpl
tloubrieu-jpl merged commit b0347a0 into develop Feb 5, 2026
1 check passed
@tloubrieu-jpl
tloubrieu-jpl deleted the edunn-fixes branch February 5, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants