Conversation
…D, 2D/3D or n/a) (4ian#8303) Only show in developer changelog
Don't show in changelog
- Removed the + button that was wrongly shown to add an instance variable (instance variables can only "override" the values of the variables defined in the object) - Fix paste/delete a child of structure/array of a variable that is re-defined in instances variables. Previously it was not possible to paste a variable as a child of a instance variable that was a structure/array. This is now possible (and fully supported - you can't add new variables at the root, but items inside structures/arrays can be changed).
…when editing variables
This updates the translations by downloading them from Crowdin and compiling them for usage by the app. Please double check the values in `newIDE/app/src/locales/LocalesMetadata.js` to ensure the changes are sensible. Co-authored-by: 4ian <1280130+4ian@users.noreply.github.com>
…it (4ian#8319) - For advanced use cases where it's important to run events on each instance of an object with an ordering, the For Each can now have an ordering: an expression can be written and will be evaluated for each instance separately. The For Each will then execute for each instance in the order of the result of the expression. - It's possible to change the direction (ascending or descending) - It's also possible to give a limit (for example, 1 will allow to pick just the instance with the highest/lowest value for the expression). - Examples are provided in the UI for common use cases (maximum value of a variable, health points, ammo, distance to another object...)
Only show in developer changelog
Don't show in changelog
Do not show in changelog
…n#8332) Don't show in changelog
…e documentation (4ian#8335) - Don't show in changelog
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f859af902
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| outputCode += "if (" + forEachLimitVar + " >= 0 && " + | ||
| forEachSortedList + ".length > " + forEachLimitVar + | ||
| ") " + forEachSortedList + ".length = " + | ||
| forEachLimitVar + ";\n"; |
There was a problem hiding this comment.
When limit evaluates to a positive non-integer (for example 1.5 from a variable or expression), this branch assigns it directly to array.length, which throws RangeError: Invalid array length in JavaScript and aborts the generated ForEach event at runtime. Because limit is a generic number expression, fractional results are valid inputs here and should be normalized (for example via Math.floor and lower-bound clamping) before truncating the sorted list.
Useful? React with 👍 / 👎.
5 participants
No description provided.