Conversation
* Profile not loading properly after log in / sign up * Ai requests not loading properly if opened too quickly * 3D Model previews not loading on desktop
Only show in developer changelog
* Batch of fixes (4ian#8452) * Profile not loading properly after log in / sign up * Ai requests not loading properly if opened too quickly * 3D Model previews not loading on desktop * Fix the default value displayed for the related function of action with operator (4ian#8453) * Add a callback after the in-game editor stepped (4ian#8457) Only show in developer changelog * Fix JS event API level target (4ian#8459) --------- Co-authored-by: Clément Pasteau <4895034+ClementPasteau@users.noreply.github.com> Co-authored-by: D8H <Davy.Helard@gmail.com>
Do not show in changelog
…outside the editor (4ian#8455)
* Make the home page navigation sidebar collapsible * .. * Update HomePageMenuBar.js * Enlarge collapsed home page navigation icons
…alling visible assets (4ian#8466)
…not consistent with other platforms) (4ian#8467)
* Make the home page navigation sidebar collapsible * Remove flagging the game as mobile on every build (4ian#8465) * Trigger unsaved changes when AI works, only when project actually modified (4ian#8464) * Fix asset store pagination when navigating folders and correctly installing visible assets (4ian#8466) * Fix rename context menu item not working anymore on the web-app (4ian#8468) * Fix resources added on Windows using a backslash instead of a slash (not consistent with other platforms) (4ian#8467) * Operators in instructions now automatically defaults to first value (4ian#8471) --------- Co-authored-by: Clément Pasteau <4895034+ClementPasteau@users.noreply.github.com>
- Also fix hot reloading of Spine objects in preview and the 3D editor
Don't show in changelog
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 974dc81997
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| onChange={(e, text) => { | ||
| eventsFunctionsExtension.setFullName(text); |
There was a problem hiding this comment.
CompactTextField calls onChange(newValue, reason), but this handler stores the second argument (reason) into the extension model. As a result, editing this field writes values like "keyInput"/"iconControl" instead of the user-entered text, so the extension display name becomes corrupted as soon as the user types. The same callback pattern is repeated for the Version field in this file.
Useful? React with 👍 / 👎.
| const operators = | ||
| mapTypeToRelationalOperators[extraInfo] || | ||
| mapTypeToRelationalOperators.unknown; | ||
| instruction.setParameter(i, operators[0]); |
There was a problem hiding this comment.
This now initializes every relational operator with operators[0]; for time parameters, mapTypeToRelationalOperators is ordered as ['<', '>', '<=', '>='], so newly inserted time conditions default to < instead of the previous >=. That flips the initial semantics of common timer conditions (they start true immediately rather than after a delay), which is a behavior regression for users who rely on default operators and only fill the operand.
Useful? React with 👍 / 👎.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🟡 Default relational operator for 'time' type changed from '>=' to '<'
The refactoring to unify operator defaults via operators[0] changed the default relational operator for the time type from '>=' to '<'. The mapTypeToRelationalOperators['time'] array is ['<', '>', '<=', '>='], so operators[0] yields '<'. Previously, a dedicated defaultOperators map (newIDE/app/src/EventsSheet/ParameterFields/RelationalOperatorField.js) explicitly set time: '>='. For timer conditions (the primary use case), '>=' is the natural default (e.g., "if timer ≥ 2 seconds, do something"), whereas '<' is less intuitive. The same incorrect default is also applied in newIDE/app/src/InstructionOrExpression/SetupInstructionParameters.js:56-61 when setting up new instructions.
(Refers to line 30)
Was this helpful? React with 👍 or 👎 to provide feedback.
6 participants
Uh oh!
There was an error while loading. Please reload this page.