fix(packaging): canonical SPDX license expression (0.2.1) - #4
Conversation
…loor - license = "GPL-3.0-only" instead of the deprecated "GPL-3.0" SPDX identifier. Same license, canonical machine-readable spelling; setuptools warns on deprecated identifiers and PyPI validates them. - Build requirement raised to setuptools>=77, the first release implementing PEP 639 (a string license holding an SPDX expression, plus license-files). setuptools>=68 allowed versions that reject a string license value, so a clean-environment build could resolve a setuptools too old for this metadata. Version bumped to 0.2.1 with the matching CHANGELOG section and comparison links. Verified: 88 tests pass, ruff clean.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
t0kubetsu has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Warning Review limit reached
Next review available in: 37 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
PR #4 (canonical SPDX license expression) landed while this branch was open. pyproject.toml auto-merged cleanly -- their license/build-requires change and this branch's ruff ISC selection touch different keys. CHANGELOG.md conflicted because #4 opened a released [0.2.1] section where this branch had added [Unreleased] entries. Resolved by keeping both in their proper places: the ISC004 fix stays unreleased, [0.2.1] follows as the shipped section.
1 participant
Problem
pyproject.tomldeclaredlicense = "GPL-3.0". That is a deprecated SPDXidentifier: setuptools warns on it and PyPI validates license expressions, so the
correct spelling is
GPL-3.0-only(orGPL-3.0-or-later). The license itself isnot changing — only its machine-readable form.
The build requirement was also under-constrained at
setuptools>=68. This filealready relies on PEP 639 — a string
licenseholding an SPDX expression, pluslicense-files— which setuptools only implements from 77. Versions 68-76reject a string
licensevalue, so a build in a clean environment could resolvea setuptools too old to understand this metadata and fail. It works locally only
because pip's build isolation happens to fetch a current setuptools.
Change
license = "GPL-3.0-only"requires = ["setuptools>=77", "wheel"]pyproject.tomland the__init__.pyfallbackliteral, with the matching
CHANGELOG.mdsection and comparison links.No source code, API or behaviour changed.
Verification
The equivalent change was verified end-to-end on a built wheel
(
License-Expression: GPL-3.0-only,dist-info/licenses/LICENSEpresent).Part of an org-wide sweep: every module carried the same deprecated identifier.
Follows quantumvalidator, which shipped this in v0.6.4.