Description
When looking at the CCPP framework repository in GitHub, one is met with an ugly ❌ besides the latest commits. This is due to an old set of CI tests in .github/workflows/python.yaml, which is failing for unclear reasons but appears to be due to the movement of the tests directory to test_prebuild in #515. This was not caught at the time because this old test is set to only run on the NCAR/ccpp-framework repository, so PRs from forks will not invoke this test.
In addition, while #515 did attempt to implement the old prebuild tests in test_metadata_parser.py and test_mkstatic.py, it appears to have done so incorrectly, calling them with python3 (a no-op, since there is no main routine) rather than pytest.
Steps to Reproduce
Look at the ❌ . Here is the latest example: https://github.com/NCAR/ccpp-framework/actions/runs/7494120637/job/20401325581
Additional Context
To me the best solution to this is to correctly run these tests in the new .github/workflows/prebuild.yaml, and remove the old, deprecated .github/workflows/python.yaml
Output
See latest failed test log: https://github.com/NCAR/ccpp-framework/actions/runs/7494120637/job/20401325581
Description
When looking at the CCPP framework repository in GitHub, one is met with an ugly ❌ besides the latest commits. This is due to an old set of CI tests in
.github/workflows/python.yaml, which is failing for unclear reasons but appears to be due to the movement of thetestsdirectory totest_prebuildin #515. This was not caught at the time because this old test is set to only run on the NCAR/ccpp-framework repository, so PRs from forks will not invoke this test.In addition, while #515 did attempt to implement the old prebuild tests in
test_metadata_parser.pyandtest_mkstatic.py, it appears to have done so incorrectly, calling them withpython3(a no-op, since there is no main routine) rather thanpytest.Steps to Reproduce
Look at the ❌ . Here is the latest example: https://github.com/NCAR/ccpp-framework/actions/runs/7494120637/job/20401325581
Additional Context
To me the best solution to this is to correctly run these tests in the new
.github/workflows/prebuild.yaml, and remove the old, deprecated.github/workflows/python.yamlOutput
See latest failed test log: https://github.com/NCAR/ccpp-framework/actions/runs/7494120637/job/20401325581