Clean up/fix ccpp_prebuild CI tests#533
Merged
Conversation
…build.yaml needs to be updated to run pytest on the test scripts rather than running them directly
mkavulich
requested review from
climbfuji,
gold2718 and
grantfirl
as code owners
climbfuji
approved these changes
Feb 23, 2024
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Thanks very much for making these changes, this looks good to me!
dustinswales
approved these changes
Feb 23, 2024
Member
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issues mentioned in #532 so that CI tests should now all run successfully:
test_metadata_parser.pyandtest_mkstatic.pywithpytestpython.yamlandpytest.iniIn addition, I implemented multi-version python testing (all active Python versions: 3.8 through 3.12) rather than just a single version.
@climbfuji Please double-check my assessment of your changes in #515 to make sure I'm not misunderstanding. Thanks!
User interface changes?: No
Fixes: #532 CI tests for prebuild not running correctly on main branch
Testing:
test removed: None
unit tests: CI now runs correctly
system tests: None
manual testing: None