Cleanup/manual review of feature/cagen-v1 part 1 + 2 minor improvements#764
Merged
Conversation
…t doesn't hurt is today w.r.t. escaping periods in decimals in capgen/metadata/parse_tools/fortran_conditional.py
…n, preserve default umask
…guments, trim down docstring tests (covered in unit tests and end-to-end tests
…apgen/metadata/metadata_table.py accordingly
… case insensitive (#766) Adds to_lower routine to capgen/src/ccpp_constituent_prop_mod.F90 and uses that to make the ccpp_constituent_index, ccpp_constituent_indices, and <host>_const_get_index interfaces case insensitive.
…ailing unit test
…ble conversions (#767) + bug fixes + unit test updates (#768) Fix the trailing comments after the variable conversions in the Group caps. Contributors: @dustinswales
…d variables from datatable
climbfuji
changed the title
climbfuji
marked this pull request as ready for review
July 14, 2026 20:15
climbfuji
changed the title
dustinswales
approved these changes
Jul 15, 2026
dustinswales
left a comment
dustinswales
left a comment
Member
There was a problem hiding this comment.
I like the idea of being able to query the datatable for suite-variables.
Looks good to me.
Collaborator
Author
|
Tested this successfully with NEPTUNE, CAM-SIMA tests are waiting for an update of the test data. |
peverwhee
approved these changes
Jul 16, 2026
peverwhee
left a comment
peverwhee
left a comment
Collaborator
There was a problem hiding this comment.
did a very high-level review of the clean-up stuff. looks OK to me.
Officially signing off on this despite the couple of CAM-SIMA tests that are failing - those test will pass once ESCOMP/CAM-SIMA#518 is merged
Collaborator
Author
|
Great, thanks. I'll keep an eye on the CAM-SIMA PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets the feature/capgen-v1 branch with follow-up and cleanup changes from manual code reviews (
capgen/metadata/parse-tools/*) plus a few selected, minor improvements. This branch is being used by the CAM-SIMA feature branches that replace the original capgen v0 with the new capgen v1.feature/capgen-v1.capgen/metadata/parse_tools/parse_source.py. Some of the removed features were (ab)used by CAM-SIMA and are now in the updated capgen compatibility layer in the CAM-SIMA feature branch.capgen/metadata/parse_tools/parse_log.py. Requires a tiny change in the CAM-SIMA compatibility layer (now in the (CAM-SIMA feature branch).capgen/metadata/parse_tools/fortran_conditional.py.capgen/metadata/parse_tools/io_helpers.py: better documentation, preserve defaultumask.capgen/metadata/parse_tools/xml_tools.py: remove unneeded arguments, trim down docstring tests (covered in unit tests and end-to-end tests). Requires small changes in the CAM-SIMA compatibility layer (now in the (CAM-SIMA feature branch).capgen/metadata/parse_tools/parse_checkers.py, updatecapgen/metadata/metadata_table.pyaccordingly.--suite-variablesto retrieve suite-owned variables from datatable.User interface changes?: No (so far - the goal of these clean up changes is no API changes).
Issues
This is part 1 of the cleanup/complete manual review of the capgen v1 codebase.
Testing