removing llvm#886
Merged
Merged
Conversation
Collaborator
|
I agree that it is better to remove the JIT version for now and we can always recover it when we find it is helpful. Thanks for doing it! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #886 +/- ##
==========================================
- Coverage 94.49% 94.37% -0.13%
==========================================
Files 71 63 -8
Lines 3850 3163 -687
==========================================
- Hits 3638 2985 -653
+ Misses 212 178 -34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
boulderdaze
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the JIT solver
We don't use this solver, and we have to use a very outdated version of llvm. If we still want a JIT solver, we should look into MLIR, which seems to be a better option anyway.
I personally have no problem removing this since it's in our git history and should be relatively easy to add back, but as of now, anytime we make a change to the CPU/GPU interfaces, we have to replicate that for the JIT solver that we aren't using and aren't shipping with musica. Maybe it's time we let it go
Let me know your thoughts