Skip to content

removing llvm#886

Merged
K20shores merged 3 commits into
mainfrom
remove_llvm
Dec 10, 2025
Merged

removing llvm#886
K20shores merged 3 commits into
mainfrom
remove_llvm

Conversation

@K20shores
Copy link
Copy Markdown
Collaborator

@K20shores K20shores commented Dec 10, 2025

Removes the JIT solver

We don't use this solver, and we have to use a very outdated version of llvm. If we still want a JIT solver, we should look into MLIR, which seems to be a better option anyway.

I personally have no problem removing this since it's in our git history and should be relatively easy to add back, but as of now, anytime we make a change to the CPU/GPU interfaces, we have to replicate that for the JIT solver that we aren't using and aren't shipping with musica. Maybe it's time we let it go

Let me know your thoughts

@sjsprecious
Copy link
Copy Markdown
Collaborator

I agree that it is better to remove the JIT version for now and we can always recover it when we find it is helpful. Thanks for doing it!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.37%. Comparing base (cc68545) to head (314ad6c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #886      +/-   ##
==========================================
- Coverage   94.49%   94.37%   -0.13%     
==========================================
  Files          71       63       -8     
  Lines        3850     3163     -687     
==========================================
- Hits         3638     2985     -653     
+ Misses        212      178      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@sjsprecious sjsprecious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@K20shores K20shores merged commit fa5c5ec into main Dec 10, 2025
26 checks passed
@K20shores K20shores deleted the remove_llvm branch December 10, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants