fix(image): read the Flutter version from the SDK manifest - #261
Merged
Conversation
The build reached the Flutter step and failed: cat: .../flutter/stable-3.44.9-x64/flutter/version: No such file or directory The plain `version` file older SDKs carried is gone. Flutter 3.x ships bin/cache/flutter.version.json, whose frameworkVersion is 3.44.9 and whose frameworkRevision matches the hash the release manifest publishes for that archive. Verified against the real archive rather than assumed: the tarball does carry a top-level flutter/ directory, so the nested path was right, and it already contains 225 engine artifact files under bin/cache/artifacts. The SDK therefore needs no first-run download either at build time or in a job. Claude-Session: https://claude.ai/code/session_01HMPUfMTrzqwrcgDCFvjnFG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The b14 build reached the Flutter step and failed:
The plain
versionfile older Flutter SDKs carried no longer exists. 3.x shipsbin/cache/flutter.version.json:{ "frameworkVersion": "3.44.9", "frameworkRevision": "6b182d2c7585eba26d4edce0f97630effd256c33", ... }frameworkRevisionis exactly thehashthe Flutter release manifest publishes for this archive, so the file is a real identity check rather than a convenient string.Verified against the archive, not assumed
I downloaded the 1.55 GB archive and inspected it before changing anything:
flutter/directory, so the nestedflutter/stable-<v>-x64/flutter/bin/flutterpath the consumer's action probes was right;flutter/bin/dartis present;flutter/bin/cache/artifacts/— the engine is precached in the archive, so neither the image build nor a job triggers a first-run download.That last point was the reason for avoiding
flutter --versionin the first place, and it turns out the concern does not even arise for this archive. The manifest read stays anyway: it is offline, exact, and does not depend on first-run behaviour continuing to be cheap.Note
The failed build cleaned up after itself — no builder or smoke instance was left on the member. The recipe fingerprint moves again with the provisioner change.
https://claude.ai/code/session_01HMPUfMTrzqwrcgDCFvjnFG