fix(observability): a sql alert omits the promql condition entirely - #332
Merged
Conversation
OpenObserve refuses to deserialize an empty operator, and the zero-value promql_condition a sql alert carried had exactly that. The condition is now a pointer set only on the promql path; the first live apply of the tenant overlay found this with a 422 and converged once omitted -- both anton_ alerts are live and read back equal. Claude-Session: https://claude.ai/code/session_01LsGid6U5RrQdFvJmvYdGCF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first live apply of the tenant overlay returned 422: OpenObserve refuses
promql_conditionwith an empty operator, which is exactly what the zero struct serialized on sql alerts.PromQLConditionis now a pointer set only on the promql path (omitemptydrops it for sql). Applied live: bothanton_alerts created, read-back converged (state: managed), 30 managed alerts total.https://claude.ai/code/session_01LsGid6U5RrQdFvJmvYdGCF