fix(observer): the visibility stream exists before the first hold - #339
Merged
Conversation
The reconciler rightly refuses an alert over a stream that does not exist, and the per-member visibility gauge only emitted while a member was held out -- so the guard rule could not be installed until the very condition it guards had already happened. An always-emitted total (gha_fleet_visibility_held_out_members, zero in steady state) creates the stream from the first scrape; the rule keys on it, and the labeled per-member rows remain for attribution. Claude-Session: https://claude.ai/code/session_01LsGid6U5RrQdFvJmvYdGCF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first live reconcile of
fleet_visibility_degradedblocked on stream prerequisites: the labeled gauge only emitted during a hold, so the guard rule could not install before the condition it guards. An always-emitted total (gha_fleet_visibility_held_out_members, 0 in steady state) creates the stream at first scrape; the rule keys on it; per-member labeled rows stay for attribution.internal/fleetobserveis not in the provider dependency set — no release.https://claude.ai/code/session_01LsGid6U5RrQdFvJmvYdGCF