fix(observe): keep platform health during a full online drain - #402
Merged
Conversation
Held-out visibility still applies only to offline drain-marked members, so queue and assigned pages keep firing. When every cluster member has a drain reason, uncovered-beyond-grace is expected capacity loss and must not zero gha_fleet_platform_healthy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An authorized online drain of every compute member pages
fleet_platform_unhealthybecause uncovered-beyond-grace still zeros platform health. The listing is complete (empty is the truth), sogha_fleet_visibility_held_out_memberscorrectly stays 0 and queue/assigned pages keep firing.When every cluster member has a drain reason, uncovered-beyond-grace is expected capacity loss. Platform health stays up. A partial drain still fails health: an undrained sibling can still place work.
Verify
gofmt -l internal/fleetobservego vet ./internal/fleetobserve/go test ./internal/fleetobserve/ ./cmd/gha-fleet-observer/