fix(recovery): integrate exact evidence and safe attempt admission - #421
Merged
Conversation
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stalled subjects remain visible while recovery is ineligible, and recovery only accepts a complete disjoint partition of the original identities. Interrupted attempts verify their result but never replay stale restart authorization.
This signed integration incorporates the reviewed #415 implementation, then closes additional evidence gaps: checkpoint/restart failures retain all unresolved subjects; FileStore permits only one unfinished attempt when different decisions race; cooldown, startup-grace, heartbeat and duplicate suppression do not label retained stuck subjects healthy.
Validation:
go test -race ./internal/schedulerrecovery -count=1and fullmake verifyon Go 1.26.7 passed (formatting, vet, full race suite, controller-release-manifest tests and build). Regressions exercise real FileStore concurrent distinct attempts, failure receipts and suppressed incident health. No runtime restart, deployment, derivative rebuild or fleet latency acceptance is claimed.The compatible deployment adapter must prove semantic transitions and revalidate original subjects. Admission fencing/scoped repair and serialization of all Tick/resume/action owners remain explicit follow-up; one-attempt FileStore admission alone is not that protocol. Install the compatible binary before an adapter emitting recovery_blockers, preserve history and test the pair.
Supersedes #415 for signed integration. #416's alternative restart_blockers semantics and partial-resume restart are not adopted. No private runtime evidence is included.