chore(ci): advance the release action pins - #3
Merged
Conversation
`actions/download-artifact` v5.0.0 to v8.0.1 and `attest-build-provenance` v4.1.1 to v4.2.2, taken across every tree in this estate at once so seven trees do not stop being the same tree one pull request at a time. Both SHAs resolved from the tags their comments name, and `download-artifact` still takes `merge-multiple` at v8 -- three majors is worth checking rather than assuming, since the publish job's whole shape depends on that one input.
Testing against a real Grok home found two defects with one cause. A live installation could not be touched at all: `~/.grok` keeps a symlink at `bin/grok`, and the capture copied the whole target, met the link and refused it -- correctly, since a link in a slot is a pointer rather than bytes. So `install` failed outright on any real install, and would on any product keeping a link anywhere in its home. And it copied 517 MB to protect four kilobytes. That home holds 474 MB of downloads plus a marketplace cache, a vendored runtime and logs; one operation doubled the directory to 1.2 GB. The cause of both: capture took the whole target minus what to avoid, while restore reads back exactly the declared namespaces and nothing else. Everything else in a slot was bytes no code here could ever restore. Capture now takes the paths to include. The same home produces a 20 KB slot, stays at 626 MB, and installs without meeting the link. Symlinks are still refused inside a captured path, named directly or found while walking. Also resolves this tree's `Cargo.lock`: CI builds with `--locked`, and a tree without one fails with "cannot create the lock file", which reads like a CI problem rather than a missing file.
Rewriting the symlink test to cover both shapes replaced its `#[cfg(unix)]` along with its body, so `std::os::unix::fs::symlink` reached the Windows runner and the crate failed to compile there -- red on one job for a reason unrelated to what the tests assert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/download-artifactv5.0.0→v8.0.1 andattest-build-provenancev4.1.1→v4.2.2, taken across every tree in the estate at once.Both SHAs resolved from the tags their comments name, and
merge-multiplestill exists at v8 — three majors is worth checking, since the publish job depends on that input.Supersedes the two Dependabot pull requests on this repository.