fix(plan): say which problem the expiry has, and say it when planning - #4
Merged
Merged
Conversation
An expiry of `2026-08-23T22:21:39Z` was refused as `stale` with "this plan expired before it was applied", while the deadline was half an hour in the future. What was wrong is that the shape carries no milliseconds, and an expiry this build cannot parse is treated as expired -- fail-closed, and right to be. The message sent the reader to a clock when the answer was in a format. The check also moved to where the caller can act on it: `plan-operation` was issuing plans whose expiry could never authorize an apply.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An expiry of
2026-08-23T22:21:39Zrefused asstale— "this plan expired before it was applied" — while the deadline was half an hour in the future. The real problem: no milliseconds in the shape, and an unparseable expiry is treated as expired (fail-closed, and right). The message sent the reader to a clock when the answer was in a format.The check also moved to where the caller can act on it:
plan-operationwas issuing plans whose expiry could never authorize an apply.