fix: what remove takes, said to the person it takes it from - #40
Merged
Conversation
remove_managed walks native_namespaces and calls remove_dir_all on each, so a namespace goes whole. Where a declaration keeps a transition window open that is wider than what this provider wrote: cursor owns plugins and plugins/local, our bytes are under the second, and remove takes the first -- where a marketplace plugin lives. Recoverable rather than destructive, and measured: pool.capture runs before every mutation over exactly those namespaces, restore returns them byte-exact, the window is ten rolling slots and a hold exempts one. But that only comforts someone who was told there was something to restore. remove now names the namespaces, says they go whole, and says the capture holds whatever else was under them -- asserted in the lifecycle probe, so it is checked on all three systems. Also: opencode moves to 1.18.24, re-fetched and re-hashed rather than copied; every other baseline's verified_at advances to record confirmation. Claude-Session: https://claude.ai/code/session_01BgFJL6e1vwwzimvP9tJDHY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered from the private source.
remove prints Removed everything owns. The sentence is true and is heard wrong.
remove_managed walks native_namespaces and calls remove_dir_all on each entry, so a namespace goes whole. A person reads that as 'the files it installed' -- and where a declaration keeps a transition window open those are different sets by a wide margin. Cursor owns plugins and plugins/local; every byte this provider writes is under the second, and remove takes the first, which is where a marketplace plugin lives.
Recoverable rather than destructive, and measured: pool.capture runs before every mutation over exactly those namespaces, so the slot holds what went byte-exact and restore returns it. Ten rolling slots; a hold exempts one entirely. But that is only a comfort to someone who was told there was something to restore.
It now names the namespaces, says they go whole, and says the capture holds whatever else was under them. Asserted in the lifecycle probe rather than a unit test, because the words exist only on the human surface -- which puts the check on ubuntu, macOS and Windows.
Also here: opencode 1.18.23 -> 1.18.24, re-fetched and re-hashed rather than copied, and every other baseline verified_at advanced to record that the bytes were confirmed rather than assumed unchanged.
https://claude.ai/code/session_01BgFJL6e1vwwzimvP9tJDHY