kibana: manage file logging with variables - #515
Merged
Conversation
Kibana previously only logged to the journal and its logging could only be configured through the verbatim kibana_extra_config passthrough. Add kibana_manage_logging (off by default, so existing behaviour is kept) plus variables for path, file name, level, layout, console output and rotation. The settings are rendered as flat dotted keys, matching both the rest of kibana.yml.j2 and the style of Elastic's shipped config/kibana.yml. Rotation is handled by Kibana's rolling-file appender, so no logrotate is needed. The role also creates the log directory for the kibana user, which the passthrough could not do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kibana previously only logged to the journal and its logging could only be configured through the verbatim kibana_extra_config passthrough.
Add kibana_manage_logging (off by default, so existing behaviour is kept) plus variables for path, file name, level, layout, console output and rotation. The settings are rendered as flat dotted keys, matching both the rest of kibana.yml.j2 and the style of Elastic's shipped config/kibana.yml.
Rotation is handled by Kibana's rolling-file appender, so no logrotate is needed. The role also creates the log directory for the kibana user, which the passthrough could not do.
Closes #142