Folia support

[Potothingi]

I hope someday this plugin will support Folia.
Folia isn't a stable release yet, so don't rush.

Currently, 'ProtocolLib, Vault, LuckPerms, PlaceholderAPI, EssentialsX, ViaVersion, ViaBackwards, CoreProtect, DiscordSRV, Chunky, Spark' plugins already support Folia, or Folia support is ready in pull requests.

https://docs.papermc.io/folia
https://github.com/PaperMC/Folia#plugin-compatibility

[Tanguygab]

In case you use BungeeCord, TAB-Bridge already supports Folia so you could use TAB on Bungee and put the bridge on Folia. Though the main plugin doesn't support it just yet

[Potothingi]

You can refer to the commits that other plugins have added to support Folia.

ViaVersion/ViaVersion@7c9c602
ViaVersion/ViaVersion@c46bb5b

ViaVersion/ViaBackwards@4293289

pop4959/Chunky@2a3f089
pop4959/Chunky@38e99a8
pop4959/Chunky@3666d58

dmulloy2/ProtocolLib@65a9ef5

https://github.com/MilkBowl/Vault/pull/915/files

https://github.com/LuckPerms/LuckPerms/pull/3615/files

https://github.com/lucko/spark/pull/312/files

PlaceholderAPI/PlaceholderAPI@95786e3

https://github.com/EssentialsX/Essentials/pull/5291/files

PlayPro/CoreProtect@7170e29
PlayPro/CoreProtect@ace870b
PlayPro/CoreProtect@f2934fd

DiscordSRV/DiscordSRV@812c9b0

ocelotpotpie/FreedomChat@dffbd3d

[NEZNAMY]

Folia isn't a stable release yet, so don't rush.

I don't rush, just everyone else around does and makes requests while they are closed.
In TAB's case, it's not as simple as calling a different method for scheduling a task. While there might be more, I noticed the following problems:

• Bukkit.getTPS() is hardcoded to always return 20. What should TAB do about this? Should the placeholder just be considered not working? What if people want to display average or min tps? That would require a deep hook into Folia. Would that still be TAB's job? Shouldn't a PlaceholderAPI expansion for folia be made instead? Same for Bukkit.getAverageTickTime() (0).
• Sync placeholders no longer make sense. This could be a problem, for example:
  • Placeholders like %server_total_entities% will now perma-throw.
  • Denizen placeholders have a main thread check, which now doesn't make much sense either. More plugins can/may have this as well. Should this problem be left to them or should be considered on TAB's side?
• https://github.com/NEZNAMY/TAB/blob/master/bukkit/src/main/java/me/neznamy/tab/platforms/bukkit/features/BukkitNameTagX.java#L110-L123 will throw. Should the task be scheduled? Will it not cause a deadlock on plugin reload?
• PlayerChangedWorldEvent is never called. As such, per-world content will not properly change on world switch and will remain in the state it was on join/reload. Per world playerlist doesn't properly work for this reason either. Should some iffy solution like periodically checking player's world be made or should this be considered not a TAB problem?

I can't even test folia, because it has no public downloads and the last time I tried to compile it using instructions, it failed with an error.
If none of this affects you / you don't care, mark folia as supported and use the plugin.

[Zoltus]

Folia isn't a stable release yet, so don't rush.

I don't rush, just everyone else around does and makes requests while they are closed. In TAB's case, it's not as simple as calling a different method for scheduling a task. While there might be more, I noticed the following problems:

• Bukkit.getTPS() is hardcoded to always return 20. What should TAB do about this? Should the placeholder just be considered not working? What if people want to display average or min tps? That would require a deep hook into Folia. Would that still be TAB's job? Shouldn't a PlaceholderAPI expansion for folia be made instead?

• Bukkit.getAverageTickTime() is hardcoded to return 0. See above.

• Sync placeholders no longer make sense. This could be a problem, for example:

  • Placeholders like %server_total_entities% will now perma-throw.
  • Denizen placeholders have a main thread check, which now doesn't make much sense either. More plugins can/may have this as well. Should this problem be left to them or should be considered on TAB's side?

• https://github.com/NEZNAMY/TAB/blob/master/bukkit/src/main/java/me/neznamy/tab/platforms/bukkit/features/unlimitedtags/BukkitNameTagX.java#L97-L110 will throw. Should the task be scheduled? Will it not cause a deadlock on plugin reload?

• PlayerChangedWorldEvent is never called. As such, per-world content will not properly change on world switch and will remain in the state it was on join/reload. Per world playerlist doesn't properly work for this reason either. Should some iffy solution like periodically checking player's world be made or should this be considered not a TAB problem?

I can't even test folia, because it has no public downloads and the last time I tried to compile it using instructions, it failed with an error. If none of this affects you / you don't care, mark folia as supported and use the plugin.

folia has common problem where u gotta build it 2-3 times for it to work. Did u try multiple times building it?
And u used "run ./gradlew applyPatches, then ./gradlew createReobfBundlerJar"?

[NEZNAMY]

Doesn't matter as long as I don't have answers to previous questions.

[Zoltus]

Doesn't matter as long as I don't have answers to previous questions.

Well just trying to help you, but gl figuring those things out.

[xKumorio]

@NEZNAMY

To get TPS on Folia, do the following:

    Bukkit.getAsyncScheduler().runAtFixedRate(Pitbul.instance, task1 -> player.getScheduler().run(
            Pitbul.instance,
            task2 -> {
                TickData.TickReportData report = TickRegionScheduler.getCurrentRegion()
                                                                    .getData()
                                                                    .getRegionSchedulingHandle()
                                                                    .getTickReport15s(System.nanoTime());
                tps = report.tpsData().segmentAll().average();
            }, null), 1, 1, TimeUnit.SECONDS);

MSPT

    Bukkit.getAsyncScheduler().runAtFixedRate(Pitbul.instance, task1 -> player.getScheduler().run(
            Pitbul.instance,
            task2 -> {
                TickData.TickReportData report = TickRegionScheduler.getCurrentRegion()
                                                                    .getData()
                                                                    .getRegionSchedulingHandle()
                                                                    .getTickReport15s(System.nanoTime());
                double MSPT = report.timePerTickData().segmentAll().average() / 1.0E6;

I suggest adding folia_player_region_tps and
folia_player_region_mspt placeholders

[NEZNAMY]

That sounds like something for PlaceholderAPI.