Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MILESTONE: June 2022 🔥 🔥 🔥 #7389

Open
20 of 58 tasks
simplejason opened this issue Apr 26, 2022 · 29 comments
Open
20 of 58 tasks

MILESTONE: June 2022 🔥 🔥 🔥 #7389

simplejason opened this issue Apr 26, 2022 · 29 comments
Assignees
@vthinkxie @cipchk @arturovt @wzhudev @hsuanxyz @wenqi73 @danranVm @yangjunhan

Comments

@simplejason
Copy link
Member

simplejason commented Apr 26, 2022 •
edited by HyperLife1119
Loading

MILESTONE: June

We need to implement features that are supported by ant-design but not supported by ng-zorro-antd, so we plan to carry out relevant synchronization work in May and June, we also welcome more people to participate in contributing code! 🔥 🔥 🔥
If you want to participate in the development of ng-zorro-antd, please leave your comment with information about the component you want to be responsible for 🥇
Before you start coding, please make sure you have read CONTRIBUTING.md.
Components:

Styles:
ref: #33862
@JackYumg
Copy link
Contributor

tree-select
support placement
support validation status

@ZENETOM
Copy link

ZENETOM commented Apr 26, 2022

Input
support loading of search mode
support showing character counting

@ZENETOM
Copy link

ZENETOM commented Apr 26, 2022

Modal: support dragging

@Benamin
Copy link

Benamin commented Apr 26, 2022

Message
support setting style and className
support updating message by key

@wzhudev wzhudev pinned this issue Apr 26, 2022
@TheBeard30
Copy link
Contributor

DatePicker
support validation status
support placement

@whittssg
Copy link

tree-select
fix virtualization so that it works ?

One of the many references to it not working

Thanks

@rorry121
Copy link
Contributor

rorry121 commented Apr 28, 2022 •
edited
Loading

Select
support placement(#7537)
support validation status

Notification
support top and bottom placement (#7540)
support updating message by key (it seems already supported in ng-zorro-antd )

Alert: support loop banner
Popconfirm: asynchronously close on Promise(#7533)

@JackYumg
Copy link
Contributor

JackYumg commented Apr 29, 2022 •
edited
Loading

@simplejason
我参与tree-select，自定义状态的功能。
开发过程中对标antd的功能发现，treeSelect是与select使用同一个class。
而在zorro里面实现该功能时是否采用同样的方式复用class。
如果是的话，那么任务有一定的重叠。

@simplejason
Copy link
Member Author

@simplejason 我参与tree-select，自定义状态的功能。 开发过程中对标antd的功能发现，treeSelect是与select使用同一个class。 而在zorro里面实现该功能时是否采用同样的方式复用class。 如果是的话，那么任务有一定的重叠。

默认情况下，tree-select 应该完全集成tree的功能，开发前确认class 一定是和 ant-design 同步的

@buqiyuan
Copy link
Collaborator

buqiyuan commented Apr 30, 2022 •
edited
Loading

I claim：

@JackYumg
Copy link
Contributor

JackYumg commented May 6, 2022 •
edited
Loading

@simplejason
改了之后需要怎么确认代码的正确性和合理性

https://imwuyum.club:447/components/tree-select/zh

修改后的效果预览地址

@simplejason
Copy link
Member Author

@simplejason 改了之后需要怎么确认代码的正确性和合理性

https://imwuyum.club:447/components/tree-select/zh

修改后的效果预览地址

提交 PR 后机器人会自动构建预览环境，同时 CI 会保证能正常构建，基本原则应该是跟随 ant-design 的 dom 结构与 css class 样式. (PR 规范)

After submitting the PR, the ng-zorro-bot will automatically build the preview environment, and the CI will run, the basic principle should be to follow the ant-design which means dom structure and css class style should be same with antd. (PR specification)

@simplejason simplejason mentioned this issue May 16, 2022
Merged
3 tasks
@JackYumg
Copy link
Contributor

@simplejason
ERROR: Permission to NG-ZORRO/ng-zorro-antd.git denied to JackYumg.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

推分支上来没权限？还是推得不对？

@simplejason
Copy link
Member Author

@simplejason ERROR: Permission to NG-ZORRO/ng-zorro-antd.git denied to JackYumg. fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

推分支上来没权限？还是推得不对？

Step 1: fork ng-zorro-antd
Step 2: git clone your own repo ng-zorro-antd
Step 3: follow this documention

This was referenced May 23, 2022
Merged
Merged
Merged
Merged
Merged
Merged
@simplejason
Copy link
Member Author

@rorry121 @TheBeard30 Hi guys, I noticed that you haven't implemented the status setting feature yet, I hope to take over the development if it hasn't started yet :)

@rorry121
Copy link
Contributor

ok, recently I will find time to complete others

This was referenced May 30, 2022
Merged
Merged
@TheBeard30
Copy link
Contributor

@rorry121 @TheBeard30 Hi guys, I noticed that you haven't implemented the status setting feature yet, I hope to take over the development if it hasn't started yet :)

okay

@simplejason
Copy link
Member Author

Hi @TheBeard30 @ZENETOM @rorry121 @JackYumg @buqiyuan @Benamin , 按计划我们将于六月份完成上述大部分工作，七月推出 v14 版本，大家开发过程中有任何疑问可以联系我或在钉钉群沟通（如有需要也可以单独创建微信开发讨论群），感谢各位的帮助 :)

@TheBeard30
Copy link
Contributor

好的

@sebcam sebcam mentioned this issue Jun 29, 2022
Merged
3 tasks
@sebcam
Copy link
Contributor

sebcam commented Jun 29, 2022

Hi @simplejason, if you have not implemented borderless support on input number yet, i have created a PR for it.

@TheBeard30 TheBeard30 mentioned this issue Jun 30, 2022
Merged
3 tasks
@TheBeard30
Copy link
Contributor

TimePicker
support borderless

@rorry121 rorry121 mentioned this issue Jul 1, 2022
Merged
3 tasks
@TheBeard30 TheBeard30 mentioned this issue Jul 1, 2022
Merged
3 tasks
@JackYumg
Copy link
Contributor

JackYumg commented Jul 4, 2022

@simplejason
image
因为这个问题一直过不了，但是我没改动过这个呀

@simplejason
Copy link
Member Author

@simplejason image 因为这个问题一直过不了，但是我没改动过这个呀

抱歉之前没注意到，这个可以忽略，是命名问题

@TheBeard30
Copy link
Contributor

Table
support checkbox or radio
support filter: tree/search/

@JackYumg
Copy link
Contributor

JackYumg commented Jul 28, 2022 •
edited
Loading

@simplejason 这个在CodeFactor中一直是有这个问题，哪一块的样式我没动过，其实这个功能5月份就写好了的，代码测试也通过了的

@FOWind
Copy link
Contributor

FOWind commented Sep 6, 2022 •
edited
Loading

@simplejason Is there any plan about #7207 ?
antd has refarctored cascader by select component.

@simplejason simplejason mentioned this issue Oct 24, 2022
Open
5 tasks
@simplejason simplejason unpinned this issue Nov 2, 2022
@Laffery
Copy link
Collaborator

Laffery commented Nov 24, 2022

mention
transfer
callendar
collapse

@sergioorlov
Copy link

Dear developers, what about dnd for columns of table with rows ?

@scarqin
Copy link
Contributor

scarqin commented Dec 4, 2022

@simplejason
Hi,i will created a PR for：Avatar: support responsive Size

ZENETOM added a commit to ZENETOM/ng-zorro-antd that referenced this issue Feb 26, 2023
@ZENETOM
feat(module:modal): support dragging (NG-ZORRO#7389)
8ecfc77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vthinkxie vthinkxie

@cipchk cipchk

@arturovt arturovt

@wzhudev wzhudev

@hsuanxyz hsuanxyz

@wenqi73 wenqi73

@danranVm danranVm

@yangjunhan yangjunhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests