misc bugfixes discovered in testing#119
Merged
Merged
Conversation
|
This PR has no unit test demonstrating the issue nor the fix is correct. |
Author
Tests are now added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes various bugs discovered while testing the RNA/WES/WGS that do not have any relation to the changes made to support the crispr-dav pipeline. The changes include:
SBG get_project_by_name()
self.api.projects.query(name=project_name), which returns a list of project objects whose names containproject_nameas a substring. Then, get_project_by_name() returns the first project in that list.self.api.projects.query(name=project_name)and check that names exactly match the query. If multiple or no names match, return None.SBG get_file_id()