fix: ensure that format for times can be accessed and supplied in duc… - #135
Merged
Merged
Conversation
georgeRobertson
requested changes
Aug 11, 2026
| raise exc.TypeNotFoundError(f"Callable or type ({item!r}) not found") | ||
|
|
||
|
|
||
| def resilient_get(item: object, *attribute_names: str) -> Any: |
Contributor
There was a problem hiding this comment.
Suggested change
| def resilient_get(item: object, *attribute_names: str) -> Any: | |
| def resilient_get(item: object, *attribute_names: tuple[str]) -> Any: |
?
Contributor
Author
There was a problem hiding this comment.
changed docs instead - using *args to gather into a tuple
| else dt_cast_statement | ||
| _date_format: str = getattr( # type: ignore | ||
| type_, | ||
| "DATE_FORMAT", |
Contributor
There was a problem hiding this comment.
Are you not checking for "TIME_FORMAT" here as well?
Contributor
Author
There was a problem hiding this comment.
version of spark being used doesnt support time datatype at the moment - better to not try to cast to a type that doesn't exist
…idation-engine into bug/ndit-1874_fix_time_casting
|
georgeRobertson
added a commit
that referenced
this pull request
Aug 11, 2026
* build(deps-dev): bump pymdown-extensions from 10.21.3 to 11.0.1 (#134) Bumps [pymdown-extensions](https://github.com/facelessuser/pymdown-extensions) from 10.21.3 to 11.0.1. - [Release notes](https://github.com/facelessuser/pymdown-extensions/releases) - [Commits](facelessuser/pymdown-extensions@10.21.3...11.0.1) --- updated-dependencies: - dependency-name: pymdown-extensions dependency-version: 11.0.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump cryptography from 48.0.1 to 50.0.0 (#133) Bumps [cryptography](https://github.com/pyca/cryptography) from 48.0.1 to 50.0.0. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@48.0.1...50.0.0) --- updated-dependencies: - dependency-name: cryptography dependency-version: 50.0.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: georgeRobertson <50412379+georgeRobertson@users.noreply.github.com> * fix: ensure that format for times can be accessed and supplied in duckdb casting (#135) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: stevenhsd <56357022+stevenhsd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…kdb casting
TLDR of changes
What kind of changes does this PR introduce?
Tick all that apply
Please check if the PR fulfills these requirements